Merge branch 'master' into reporting/fix-container-failure-messaging

.ci/packer_cache.sh

@@ -44,6 +44,7 @@ tar -cf "$HOME/.kibana/bootstrap_cache/$branch.tar" \
  x-pack/legacy/plugins/*/node_modules \
  x-pack/legacy/plugins/reporting/.chromium \
  test/plugin_functional/plugins/*/node_modules \
+ examples/*/node_modules \
  .es \
  .chromedriver \
  .geckodriver;

.eslintrc.js

@@ -131,12 +131,6 @@ module.exports = {
  'react-hooks/exhaustive-deps': 'off',
  },
  },
- {
- files: ['src/plugins/eui_utils/**/*.{js,ts,tsx}'],
- rules: {
- 'react-hooks/exhaustive-deps': 'off',
- },
- },
  {
  files: ['src/plugins/kibana_react/**/*.{js,ts,tsx}'],
  rules: {
@@ -170,13 +164,6 @@ module.exports = {
  'react-hooks/rules-of-hooks': 'off',
  },
  },
- {
- files: ['x-pack/legacy/plugins/infra/**/*.{js,ts,tsx}'],
- rules: {
- 'react-hooks/exhaustive-deps': 'off',
- 'react-hooks/rules-of-hooks': 'off',
- },
- },
  {
  files: ['x-pack/legacy/plugins/lens/**/*.{js,ts,tsx}'],
  rules: {
@@ -209,13 +196,6 @@ module.exports = {
  'react-hooks/rules-of-hooks': 'off',
  },
  },
- {
- files: ['x-pack/legacy/plugins/watcher/**/*.{js,ts,tsx}'],
- rules: {
- 'react-hooks/rules-of-hooks': 'off',
- 'react-hooks/exhaustive-deps': 'off',
- },
- },
 
  /**
  * Prettier

.github/CODEOWNERS

@@ -5,6 +5,8 @@
 # App
 /x-pack/legacy/plugins/lens/ @elastic/kibana-app
 /x-pack/legacy/plugins/graph/ @elastic/kibana-app
+/src/plugins/share/ @elastic/kibana-app
+/src/legacy/server/url_shortening/ @elastic/kibana-app
 /src/legacy/server/sample_data/ @elastic/kibana-app
 
 # App Architecture
@@ -14,7 +16,6 @@
 /src/plugins/kibana_react/ @elastic/kibana-app-arch
 /src/plugins/kibana_utils/ @elastic/kibana-app-arch
 /src/plugins/navigation/ @elastic/kibana-app-arch
-/src/plugins/share/ @elastic/kibana-app-arch
 /src/plugins/ui_actions/ @elastic/kibana-app-arch
 /src/plugins/visualizations/ @elastic/kibana-app-arch
 /x-pack/plugins/advanced_ui_actions/ @elastic/kibana-app-arch
@@ -28,7 +29,6 @@
 /src/legacy/core_plugins/kibana/server/routes/api/suggestions/ @elastic/kibana-app-arch
 /src/legacy/core_plugins/visualizations/ @elastic/kibana-app-arch
 /src/legacy/server/index_patterns/ @elastic/kibana-app-arch
-/src/legacy/server/url_shortening/ @elastic/kibana-app-arch
 
 # APM
 /x-pack/legacy/plugins/apm/ @elastic/apm-ui

CONTRIBUTING.md

@@ -218,6 +218,7 @@ node scripts/makelogs --auth <username>:<password>
 > The default username and password combination are `elastic:changeme`
 
 > Make sure to execute `node scripts/makelogs` *after* elasticsearch is up and running!
+
 ### Running Elasticsearch Remotely
 
 You can save some system resources, and the effort of generating sample data, if you have a remote Elasticsearch cluster to connect to. (**Elasticians: you do! Check with your team about where to find credentials**)
@@ -239,6 +240,41 @@ kibana.index: '.{YourGitHubHandle}-kibana'
 xpack.task_manager.index: '.{YourGitHubHandle}-task-manager-kibana'
 ```
 
+### Running remote clusters
+Setup remote clusters for cross cluster search (CCS) and cross cluster replication (CCR).
+
+Start your primary cluster by running:
+```bash
+yarn es snapshot -E path.data=../data_prod1
+```
+
+Start your remote cluster by running:
+```bash
+yarn es snapshot -E transport.port=9500 -E http.port=9201 -E path.data=../data_prod2
+```
+
+Once both clusters are running, start kibana. Kibana will connect to the primary cluster.
+
+Setup the remote cluster in Kibana from either `Management` -> `Elasticsearch` -> `Remote Clusters` UI or by running the following script in `Console`.
+```
+PUT _cluster/settings
+{
+ "persistent": {
+ "cluster": {
+ "remote": {
+ "cluster_one": {
+ "seeds": [
+ "localhost:9500"
+ ]
+ }
+ }
+ }
+ }
+}
+```
+
+Follow the [cross-cluster search](https://www.elastic.co/guide/en/kibana/current/management-cross-cluster-search.html) instructions for setting up index patterns to search across clusters.
+
 ### Running Kibana
 
 Start the development server.
@@ -506,7 +542,7 @@ yarn test:browser --dev # remove the --dev flag to run them once and close
 * In System Preferences > Sharing, change your computer name to be something simple, e.g. "computer".
 * Run Kibana with `yarn start --host=computer.local` (substituting your computer name).
 * Now you can run your VM, open the browser, and navigate to `http://computer.local:5601` to test Kibana.
-* Alternatively you can use browserstack 
+* Alternatively you can use browserstack
 
 #### Running Browser Automation Tests
 

config/apm.js

@@ -42,19 +42,22 @@ const { join } = require('path');
 const { execSync } = require('child_process');
 const merge = require('lodash.merge');
 
-module.exports = merge({
- active: false,
- serverUrl: 'https://f1542b814f674090afd914960583265f.apm.us-central1.gcp.cloud.es.io:443',
- // The secretToken below is intended to be hardcoded in this file even though
- // it makes it public. This is not a security/privacy issue. Normally we'd
- // instead disable the need for a secretToken in the APM Server config where
- // the data is transmitted to, but due to how it's being hosted, it's easier,
- // for now, to simply leave it in.
- secretToken: 'R0Gjg46pE9K9wGestd',
- globalLabels: {},
- centralConfig: false,
- logUncaughtExceptions: true
-}, devConfig());
+module.exports = merge(
+ {
+ active: false,
+ serverUrl: 'https://f1542b814f674090afd914960583265f.apm.us-central1.gcp.cloud.es.io:443',
+ // The secretToken below is intended to be hardcoded in this file even though
+ // it makes it public. This is not a security/privacy issue. Normally we'd
+ // instead disable the need for a secretToken in the APM Server config where
+ // the data is transmitted to, but due to how it's being hosted, it's easier,
+ // for now, to simply leave it in.
+ secretToken: 'R0Gjg46pE9K9wGestd',
+ globalLabels: {},
+ centralConfig: false,
+ logUncaughtExceptions: true,
+ },
+ devConfig()
+);
 
 const rev = gitRev();
 if (rev !== null) module.exports.globalLabels.git_rev = rev;
@@ -66,7 +69,10 @@ try {
 
 function gitRev() {
  try {
- return execSync('git rev-parse --short HEAD', { encoding: 'utf-8' }).trim();
+ return execSync('git rev-parse --short HEAD', {
+ encoding: 'utf-8',
+ stdio: ['ignore', 'pipe', 'ignore'],
+ }).trim();
  } catch (e) {
  return null;
  }

docs/apm/troubleshooting.asciidoc

@@ -42,3 +42,22 @@ Finally, this problem can also occur if you've changed the index name that you w
 The default index pattern can be found {apm-server-ref}/elasticsearch-output.html#index-option-es[here].
 If you change this setting, you must also configure the `setup.template.name` and `setup.template.pattern` options.
 See {apm-server-ref}/configuration-template.html[Load the Elasticsearch index template].
+
+==== Unknown route
+
+The {apm-app-ref}/transactions.html[transaction overview] will only display helpful information
+when the transactions in your services are named correctly.
+If you're seeing "GET unknown route" or "unknown route" in the APM app,
+it could be a sign that something isn't working like it should.
+
+Elastic APM Agents come with built-in support for popular frameworks out-of-the-box.
+This means, among other things, that the Agent will try to automatically name HTTP requests.
+As an example, the Node.js Agent uses the route that handled the request, while the Java Agent uses the Servlet name.
+
+"Unknown route" indicates that the Agent can't determine what to name the request,
+perhaps because the technology you're using isn't supported, the Agent has been installed incorrectly,
+or because something is happening to the request that the Agent doesn't understand.
+
+To resolve this, you'll need to head over to the relevant {apm-agents-ref}[Agent documentation].
+Specifically, view the Agent's supported technologies page.
+You can also use the Agent's public API to manually set a name for the transaction.

docs/development/core/public/kibana-plugin-public.httperrorresponse.md

@@ -8,7 +8,7 @@
 <b>Signature:</b>
 
 ```typescript
-export interface HttpErrorResponse extends HttpResponse 
+export interface HttpErrorResponse extends IHttpResponse 
 ```
 
 ## Properties

docs/development/core/public/kibana-plugin-public.httpfetchoptions.asresponse.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [HttpFetchOptions](./kibana-plugin-public.httpfetchoptions.md) &gt; [asResponse](./kibana-plugin-public.httpfetchoptions.asresponse.md)
+
+## HttpFetchOptions.asResponse property
+
+When `true` the return type of [HttpHandler](./kibana-plugin-public.httphandler.md) will be an [IHttpResponse](./kibana-plugin-public.ihttpresponse.md) with detailed request and response information. When `false`<!-- -->, the return type will just be the parsed response body. Defaults to `false`<!-- -->.
+
+<b>Signature:</b>
+
+```typescript
+asResponse?: boolean;
+```

docs/development/core/public/kibana-plugin-public.httpfetchoptions.md

@@ -16,6 +16,7 @@ export interface HttpFetchOptions extends HttpRequestInit
 
 | Property | Type | Description |
 | --- | --- | --- |
+| [asResponse](./kibana-plugin-public.httpfetchoptions.asresponse.md) | <code>boolean</code> | When <code>true</code> the return type of [HttpHandler](./kibana-plugin-public.httphandler.md) will be an [IHttpResponse](./kibana-plugin-public.ihttpresponse.md) with detailed request and response information. When <code>false</code>, the return type will just be the parsed response body. Defaults to <code>false</code>. |
 | [headers](./kibana-plugin-public.httpfetchoptions.headers.md) | <code>HttpHeadersInit</code> | Headers to send with the request. See [HttpHeadersInit](./kibana-plugin-public.httpheadersinit.md)<!-- -->. |
 | [prependBasePath](./kibana-plugin-public.httpfetchoptions.prependbasepath.md) | <code>boolean</code> | Whether or not the request should automatically prepend the basePath. Defaults to <code>true</code>. |
 | [query](./kibana-plugin-public.httpfetchoptions.query.md) | <code>HttpFetchQuery</code> | The query string for an HTTP request. See [HttpFetchQuery](./kibana-plugin-public.httpfetchquery.md)<!-- -->. |

docs/development/core/public/kibana-plugin-public.httphandler.md

@@ -2,12 +2,12 @@
 
 [Home](./index.md) > [kibana-plugin-public](./kibana-plugin-public.md) > [HttpHandler](./kibana-plugin-public.httphandler.md)
 
-## HttpHandler type
+## HttpHandler interface
 
-A function for making an HTTP requests to Kibana's backend. See [HttpFetchOptions](./kibana-plugin-public.httpfetchoptions.md) for options and [HttpBody](./kibana-plugin-public.httpbody.md) for the response.
+A function for making an HTTP requests to Kibana's backend. See [HttpFetchOptions](./kibana-plugin-public.httpfetchoptions.md) for options and [IHttpResponse](./kibana-plugin-public.ihttpresponse.md) for the response.
 
 <b>Signature:</b>
 
 ```typescript
-export declare type HttpHandler = (path: string, options?: HttpFetchOptions) => Promise<HttpBody>;
+export interface HttpHandler 
 ```

docs/development/core/public/kibana-plugin-public.httpinterceptor.response.md

@@ -9,17 +9,17 @@ Define an interceptor to be executed after a response is received.
 <b>Signature:</b>
 
 ```typescript
-response?(httpResponse: HttpResponse, controller: IHttpInterceptController): Promise<InterceptedHttpResponse> | InterceptedHttpResponse | void;
+response?(httpResponse: IHttpResponse, controller: IHttpInterceptController): Promise<IHttpResponseInterceptorOverrides> | IHttpResponseInterceptorOverrides | void;
 ```
 
 ## Parameters
 
 | Parameter | Type | Description |
 | --- | --- | --- |
-| httpResponse | <code>HttpResponse</code> | |
+| httpResponse | <code>IHttpResponse</code> | |
 | controller | <code>IHttpInterceptController</code> | |
 
 <b>Returns:</b>
 
-`Promise<InterceptedHttpResponse> | InterceptedHttpResponse | void`
+`Promise<IHttpResponseInterceptorOverrides> | IHttpResponseInterceptorOverrides | void`
 

docs/development/core/public/kibana-plugin-public.httpinterceptor.responseerror.md

@@ -9,7 +9,7 @@ Define an interceptor to be executed if a response interceptor throws an error o
 <b>Signature:</b>
 
 ```typescript
-responseError?(httpErrorResponse: HttpErrorResponse, controller: IHttpInterceptController): Promise<InterceptedHttpResponse> | InterceptedHttpResponse | void;
+responseError?(httpErrorResponse: HttpErrorResponse, controller: IHttpInterceptController): Promise<IHttpResponseInterceptorOverrides> | IHttpResponseInterceptorOverrides | void;
 ```
 
 ## Parameters
@@ -21,5 +21,5 @@ responseError?(httpErrorResponse: HttpErrorResponse, controller: IHttpInterceptC
 
 <b>Returns:</b>
 
-`Promise<InterceptedHttpResponse> | InterceptedHttpResponse | void`
+`Promise<IHttpResponseInterceptorOverrides> | IHttpResponseInterceptorOverrides | void`
 

docs/development/core/public/kibana-plugin-public.ihttpresponse.body.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [IHttpResponse](./kibana-plugin-public.ihttpresponse.md) &gt; [body](./kibana-plugin-public.ihttpresponse.body.md)
+
+## IHttpResponse.body property
+
+Parsed body received, may be undefined if there was an error.
+
+<b>Signature:</b>
+
+```typescript
+readonly body?: TResponseBody;
+```

docs/development/core/public/kibana-plugin-public.ihttpresponse.md

@@ -0,0 +1,21 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [IHttpResponse](./kibana-plugin-public.ihttpresponse.md)
+
+## IHttpResponse interface
+
+
+<b>Signature:</b>
+
+```typescript
+export interface IHttpResponse<TResponseBody = any> 
+```
+
+## Properties
+
+| Property | Type | Description |
+| --- | --- | --- |
+| [body](./kibana-plugin-public.ihttpresponse.body.md) | <code>TResponseBody</code> | Parsed body received, may be undefined if there was an error. |
+| [request](./kibana-plugin-public.ihttpresponse.request.md) | <code>Readonly&lt;Request&gt;</code> | Raw request sent to Kibana server. |
+| [response](./kibana-plugin-public.ihttpresponse.response.md) | <code>Readonly&lt;Response&gt;</code> | Raw response received, may be undefined if there was an error. |
+

docs/development/core/public/kibana-plugin-public.ihttpresponse.request.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [IHttpResponse](./kibana-plugin-public.ihttpresponse.md) &gt; [request](./kibana-plugin-public.ihttpresponse.request.md)
+
+## IHttpResponse.request property
+
+Raw request sent to Kibana server.
+
+<b>Signature:</b>
+
+```typescript
+readonly request: Readonly<Request>;
+```

docs/development/core/public/kibana-plugin-public.ihttpresponse.response.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-public](./kibana-plugin-public.md) &gt; [IHttpResponse](./kibana-plugin-public.ihttpresponse.md) &gt; [response](./kibana-plugin-public.ihttpresponse.response.md)
+
+## IHttpResponse.response property
+
+Raw response received, may be undefined if there was an error.
+
+<b>Signature:</b>
+
+```typescript
+readonly response?: Readonly<Response>;
+```