Address CR feedback

elastic · Nov 30, 2021 · 1b221d3 · 1b221d3
1 parent 55334d7
commit 1b221d3
Show file tree

Hide file tree

Showing 6 changed files with 6 additions and 8 deletions.
diff --git a/src/core/public/doc_links/doc_links_service.ts b/src/core/public/doc_links/doc_links_service.ts
@@ -227,7 +227,7 @@ export class DocLinksService {
  migrationApiDeprecation: `${ELASTICSEARCH_DOCS}migration-api-deprecation.html`,
  nodeRoles: `${ELASTICSEARCH_DOCS}modules-node.html#node-roles`,
  releaseHighlights: `${ELASTICSEARCH_DOCS}release-highlights.html`,
- version8ReleaseHighlights: `${ELASTIC_WEBSITE_URL}guide/en/elasticsearch/reference/8.0/release-highlights.html`,
+ version8ReleaseHighlights: `${ELASTIC_WEBSITE_URL}guide/en/elastic-stack/8.0/elastic-stack-highlights.html`,
  remoteClusters: `${ELASTICSEARCH_DOCS}remote-clusters.html`,
  remoteClustersProxy: `${ELASTICSEARCH_DOCS}remote-clusters.html#proxy-mode`,
  remoteClusersProxySettings: `${ELASTICSEARCH_DOCS}remote-clusters-settings.html#remote-cluster-proxy-settings`,

diff --git a/...grade_assistant/public/application/components/es_deprecation_logs/es_deprecation_logs.tsx b/...grade_assistant/public/application/components/es_deprecation_logs/es_deprecation_logs.tsx
@@ -47,8 +47,7 @@ export const EsDeprecationLogs: FunctionComponent = () => {
  defaultMessage: 'Elasticsearch deprecation logs',
  })}
  description={i18n.translate('xpack.upgradeAssistant.esDeprecationLogs.pageDescription', {
- defaultMessage:
- 'Review the deprecation logs to determine if your applications are using any deprecated APIs. Update your applications to prevent errors or changes in behavior after you upgrade to 8.x.',
+ defaultMessage: `Review the deprecation logs to determine if you're using any deprecated APIs. If so, update your applications before upgrading to the next major version.`,
  })}
  rightSideItems={[
  <EuiButtonEmpty

diff --git a/.../application/components/es_deprecation_logs/fix_deprecation_logs/fix_deprecation_logs.tsx b/.../application/components/es_deprecation_logs/fix_deprecation_logs/fix_deprecation_logs.tsx
@@ -38,7 +38,7 @@ const i18nTexts = {
  apiCompatibilityNoteBody: (docLink: string) => (
  <FormattedMessage
  id="xpack.upgradeAssistant.overview.apiCompatibilityNoteBody"
- defaultMessage="You can start resolving deprecation issues before upgrading to the next major version of Elastic. If needed, you can apply API compatibility headers to requests that use deprecated features. {learnMoreLink}."
+ defaultMessage="We recommend you resolve all deprecation issues before upgrading to the next major version of Elastic. If needed, you can apply API compatibility headers to requests that use deprecated features. {learnMoreLink}."
  values={{
  learnMoreLink: (
  <EuiLink href={docLink} target="_blank">

diff --git a/...ugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx b/...ugins/upgrade_assistant/public/application/components/es_deprecations/es_deprecations.tsx
@@ -46,7 +46,7 @@ const i18nTexts = {
  }),
  pageDescription: i18n.translate('xpack.upgradeAssistant.esDeprecations.pageDescription', {
  defaultMessage:
- 'You can start resolving all critical issues before upgrading to the next major version of Elastic. Before making changes, ensure you have a current snapshot of your cluster. Indices created before 7.0 will have to be reindexed or removed.',
+ 'Resolve all critical issues before upgrading to the next major version of Elastic. Before making changes, make sure you have a current snapshot of your cluster. To upgrade to 8.x, you must reindex or remove indices created before 7.0.',
  }),
  isLoading: i18n.translate('xpack.upgradeAssistant.esDeprecations.loadingText', {
  defaultMessage: 'Loading deprecation issues…',

diff --git a/...rade_assistant/public/application/components/overview/fix_issues_step/fix_issues_step.tsx b/...rade_assistant/public/application/components/overview/fix_issues_step/fix_issues_step.tsx
@@ -105,7 +105,7 @@ export const getFixIssuesStep = ({
  <p>
  <FormattedMessage
  id="xpack.upgradeAssistant.overview.fixIssuesStepDescription"
- defaultMessage="You can start resolving any critical Elasticsearch and Kibana configuration issues before upgrading to the next major version of Elastic, ignoring warnings might result in differences in behavior. {accessDeprecationLogsMessage}"
+ defaultMessage="Resolve any critical Elasticsearch and Kibana configuration issues before upgrading to the next major version of Elastic. Ignoring warnings might result in unexpected behavior. {accessDeprecationLogsMessage}"
  values={{
  accessDeprecationLogsMessage: (
  <AccessDeprecationLogsMessage

diff --git a/...ns/upgrade_assistant/public/application/components/overview/upgrade_step/upgrade_step.tsx b/...ns/upgrade_assistant/public/application/components/overview/upgrade_step/upgrade_step.tsx
@@ -16,8 +16,7 @@ const i18nTexts = {
  defaultMessage: 'Get ready for the next version of Elastic',
  }),
  upgradeStepDescription: i18n.translate('xpack.upgradeAssistant.overview.upgradeStepDescription', {
- defaultMessage:
- 'You can start resolving all critical issues in preparation for the upcoming Elastic 8.x. Be sure to back up your data again before upgrading',
+ defaultMessage: `If you've resolved all critical issues and checked your deprecation logs, you're ready for the next major version of Elastic. Check this page again before upgrading to Elastic 8.x.`,
  }),
 };