save more screenshots

elastic · Feb 23, 2017 · 3d025e9 · 3d025e9
1 parent 807b190
commit 3d025e9
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/test/functional/apps/dashboard/index.js b/test/functional/apps/dashboard/index.js
@@ -13,7 +13,7 @@ bdd.describe('dashboard app', function () {
  return remote.setWindowSize(1200,800);
  });
 
- // require('./_dashboard');
+ require('./_dashboard');
  require('./_dashboard_save');
- // require('./_dashboard_time');
+ require('./_dashboard_time');
 });
diff --git a/test/support/page_objects/common.js b/test/support/page_objects/common.js
@@ -277,7 +277,7 @@ export default class Common {
  .findByCssSelector(selector)
  .then(() => true)
  .catch(() => false);
- this.remote.setFindTimeout(defaultFindTimeout);
+ await this.remote.setFindTimeout(defaultFindTimeout);
 
  PageObjects.common.debug(`exists? ${exists}`);
  return exists;

diff --git a/test/support/page_objects/dashboard_page.js b/test/support/page_objects/dashboard_page.js
@@ -50,6 +50,7 @@ export default class DashboardPage {
  const searchFilter = await PageObjects.common.findTestSubject('searchFilter');
  PageObjects.common.debug('gotoDashboardLandingPage: search filter found? ' + searchFilter);
  });
+ await PageObjects.common.saveScreenshot('dashboard-should-be-on-landing-page');
  }
  }
 
@@ -200,11 +201,12 @@ export default class DashboardPage {
  const searchFilter = await PageObjects.common.findTestSubject('searchFilter');
  PageObjects.common.debug('searchForDashboardWithName: search Filter object found: ' + searchFilter);
  await searchFilter.click();
+ await PageObjects.common.saveScreenshot('searchForDashboardWithName-after-click');
  // Note: this replacement of - to space is to preserve original logic but I'm not sure why or if it's needed.
  await searchFilter.type(dashName.replace('-',' '));
  });
 
- return await PageObjects.header.waitUntilLoadingHasFinished();
+ await PageObjects.header.waitUntilLoadingHasFinished();
  }
 
  async getDashboardCountWithName(dashName) {

diff --git a/test/support/utils/try.js b/test/support/utils/try.js
@@ -18,7 +18,6 @@ class Try {
  let prevMessage;
 
  function attempt() {
- Log.debug('--- tryForTime: Retrying...');
  lastTry = Date.now();
 
  if (lastTry - start > timeout) {