👌 Use data test ids

elastic · Sep 22, 2020 · 40deac1 · 40deac1
1 parent ad9f4f4
commit 40deac1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/...lugins/lens/public/indexpattern_datasource/operations/definitions/ranges/range_editor.tsx b/...lugins/lens/public/indexpattern_datasource/operations/definitions/ranges/range_editor.tsx
@@ -49,6 +49,7 @@ const BaseRangeEditor = ({
  <EuiButtonEmpty
  size="xs"
  iconType="minusInCircle"
+ data-test-subj="lns-indexPattern-range-maxBars-minus"
  onClick={() =>
  setMaxBarsValue('' + Math.max(Number(maxBarsValue) - step, MIN_HISTOGRAM_BARS))
  }
@@ -69,6 +70,7 @@ const BaseRangeEditor = ({
  <EuiButtonEmpty
  size="xs"
  iconType="plusInCircle"
+ data-test-subj="lns-indexPattern-range-maxBars-plus"
  onClick={() =>
  setMaxBarsValue('' + Math.min(Number(maxBarsValue) + step, maxHistogramBars))
  }

diff --git a/...plugins/lens/public/indexpattern_datasource/operations/definitions/ranges/ranges.test.tsx b/...plugins/lens/public/indexpattern_datasource/operations/definitions/ranges/ranges.test.tsx
@@ -285,7 +285,10 @@ describe('ranges', () => {
 
  act(() => {
  // minus button
- instance.find(EuiButtonEmpty).first().prop('onClick')!({} as ReactMouseEvent);
+ instance
+ .find('[data-test-subj="lns-indexPattern-range-maxBars-minus"]')
+ .find('button')
+ .prop('onClick')!({} as ReactMouseEvent);
  jest.advanceTimersByTime(TYPING_DEBOUNCE_TIME * 4);
 
  expect(setStateSpy).toHaveBeenCalledWith({
@@ -308,7 +311,10 @@ describe('ranges', () => {
  });
 
  // plus button
- instance.find(EuiButtonEmpty).at(1).prop('onClick')!({} as ReactMouseEvent);
+ instance
+ .find('[data-test-subj="lns-indexPattern-range-maxBars-plus"]')
+ .find('button')
+ .prop('onClick')!({} as ReactMouseEvent);
  jest.advanceTimersByTime(TYPING_DEBOUNCE_TIME * 4);
 
  expect(setStateSpy).toHaveBeenCalledWith({