Review changes

elastic · Feb 4, 2020 · 5ba502c · 5ba502c
1 parent 9e52760
commit 5ba502c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 19 deletions.
diff --git a/.../triggers_actions_ui/np_ready/public/application/components/builtin_action_types/types.ts b/.../triggers_actions_ui/np_ready/public/application/components/builtin_action_types/types.ts
@@ -42,7 +42,7 @@ export interface IndexActionParams {
  index?: string;
  refresh?: boolean;
  executionTimeField?: string;
- documents?: string[];
+ documents: string[];
 }
 
 export enum ServerLogLevelOptions {
@@ -55,7 +55,7 @@ export enum ServerLogLevelOptions {
 }
 
 export interface ServerLogActionParams {
- level: ServerLogLevelOptions;
+ level?: ServerLogLevelOptions;
  message: string;
 }
 

diff --git a/...s_ui/np_ready/public/application/sections/action_connector_form/action_connector_form.tsx b/...s_ui/np_ready/public/application/sections/action_connector_form/action_connector_form.tsx
@@ -77,7 +77,7 @@ export const ActionConnectorForm = ({
  title={i18n.translate(
  'xpack.triggersActionsUI.sections.actionConnectorForm.actions.actionTypeConfigurationWarningTitleText',
  {
- defaultMessage: 'Action type may not be configured',
+ defaultMessage: 'Action type not registered',
  }
  )}
  color="warning"

diff --git a/x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/types.ts b/x-pack/legacy/plugins/triggers_actions_ui/np_ready/public/types.ts
@@ -6,14 +6,6 @@
 import { ActionType } from '../../../../../plugins/actions/common';
 import { TypeRegistry } from './application/type_registry';
 import { SanitizedAlert as Alert, AlertAction } from '../../../alerting/common';
-import {
- EmailActionParams,
- PagerDutyActionParams,
- IndexActionParams,
- ServerLogActionParams,
- WebhookActionParams,
- SlackActionParams,
-} from './application/components/builtin_action_types/types';
 export { Alert, AlertAction };
 export { ActionType };
 
@@ -51,14 +43,7 @@ export interface ActionTypeModel {
  validateConnector: (connector: any) => ValidationResult;
  validateParams: (actionParams: any) => ValidationResult;
  actionConnectorFields: React.FunctionComponent<any> | null;
- actionParamsFields:
- | React.FunctionComponent<ActionParamsProps<EmailActionParams>>
- | React.FunctionComponent<ActionParamsProps<IndexActionParams>>
- | React.FunctionComponent<ActionParamsProps<PagerDutyActionParams>>
- | React.FunctionComponent<ActionParamsProps<ServerLogActionParams>>
- | React.FunctionComponent<ActionParamsProps<SlackActionParams>>
- | React.FunctionComponent<ActionParamsProps<WebhookActionParams>>
- | null;
+ actionParamsFields: any;
 }
 
 export interface ValidationResult {