Merge branch 'master' into watcher/migrate-legacy-es-client

.ci/Jenkinsfile_baseline_capture

@@ -23,6 +23,7 @@ kibanaPipeline(timeoutMinutes: 210) {
  ) {
  withGcpServiceAccount.fromVaultSecret('secret/kibana-issues/dev/ci-artifacts-key', 'value') {
  withEnv([
+ 'BUILD_TS_REFS_DISABLE=false', // disabled in root config so we need to override that here
  'BUILD_TS_REFS_CACHE_ENABLE=true',
  'BUILD_TS_REFS_CACHE_CAPTURE=true',
  'DISABLE_BOOTSTRAP_VALIDATION=true',

.github/CODEOWNERS

@@ -272,7 +272,7 @@
 /x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/ @elastic/kibana-alerting-services
 /x-pack/test/functional_with_es_ssl/fixtures/plugins/alerts/ @elastic/kibana-alerting-services
 /docs/user/alerting/ @elastic/kibana-alerting-services
-/docs/management/alerting/ @elastic/kibana-alerting-services
+/docs/management/connectors/ @elastic/kibana-alerting-services
 #CC# /x-pack/plugins/stack_alerts @elastic/kibana-alerting-services
 
 # Enterprise Search

.telemetryrc.json

@@ -2,6 +2,8 @@
  {
  "output": "src/plugins/telemetry/schema/oss_plugins.json",
  "root": "src/plugins/",
- "exclude": []
+ "exclude": [
+ "src/plugins/kibana_usage_collection/server/collectors/config_usage/register_config_usage_collector.ts"
+ ]
  }
 ]

config/kibana.yml

@@ -23,7 +23,7 @@
 #server.publicBaseUrl: ""
 
 # The maximum payload size in bytes for incoming server requests.
-#server.maxPayloadBytes: 1048576
+#server.maxPayload: 1048576
 
 # The Kibana server's name. This is used for display purposes.
 #server.name: "your-hostname"

docs/apm/agent-configuration.asciidoc

@@ -46,7 +46,7 @@ Go Agent:: {apm-go-ref}/configuration.html[Configuration reference]
 Java Agent:: {apm-java-ref}/configuration.html[Configuration reference]
 .NET Agent:: {apm-dotnet-ref}/configuration.html[Configuration reference]
 Node.js Agent:: {apm-node-ref}/configuration.html[Configuration reference]
-PHP Agent:: _Not yet supported_
+PHP Agent:: {apm-php-ref}/configuration.html[Configuration reference]
 Python Agent:: {apm-py-ref}/configuration.html[Configuration reference]
 Ruby Agent:: {apm-ruby-ref}/configuration.html[Configuration reference]
 Real User Monitoring (RUM) Agent:: {apm-rum-ref}/configuration.html[Configuration reference]

docs/developer/getting-started/index.asciidoc

@@ -3,6 +3,21 @@
 
 Get started building your own plugins, or contributing directly to the {kib} repo.
 
+[discrete]
+[[developing-on-windows]]
+=== Developing on Windows
+
+In order to support Windows development we currently require you to use one of the following:
+
+- https://git-scm.com/download/win[Git bash] (other bash emulators like https://cmder.net/[Cmder] could work but we did not test them)
+- https://docs.microsoft.com/en-us/windows/wsl/about[WSL]
+
+As well as installing https://www.microsoft.com/en-us/download/details.aspx?id=48145[Visual C++ Redistributable for Visual Studio 2015].
+
+Before running the steps listed below, please make sure you have installed everything 
+that we require and listed above and that you are running the mentioned commands 
+through Git bash or WSL.
+
 [discrete]
 [[get-kibana-code]]
 === Get the code

docs/developer/getting-started/monorepo-packages.asciidoc

@@ -63,6 +63,7 @@ yarn kbn watch-bazel
 
 - @elastic/datemath
 - @kbn/apm-utils
+- @kbn/babel-preset
 - @kbn/config-schema
 - @kbn/tinymath
 - @kbn/utility-types

docs/developer/plugin-list.asciidoc

@@ -392,6 +392,10 @@ actitivies.
 |The features plugin enhance Kibana with a per-feature privilege system.
 
 
+|{kib-repo}blob/{branch}/x-pack/plugins/file_data_visualizer[fileDataVisualizer]
+|WARNING: Missing README.
+
+
 |{kib-repo}blob/{branch}/x-pack/plugins/file_upload[fileUpload]
 |WARNING: Missing README.
 

docs/development/core/public/kibana-plugin-core-public.doclinksstart.links.md

@@ -8,6 +8,9 @@
 
 ```typescript
 readonly links: {
+ readonly canvas: {
+ readonly guide: string;
+ };
  readonly dashboard: {
  readonly guide: string;
  readonly drilldowns: string;

docs/development/core/public/kibana-plugin-core-public.navigatetoappoptions.openinnewtab.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-public](./kibana-plugin-core-public.md) &gt; [NavigateToAppOptions](./kibana-plugin-core-public.navigatetoappoptions.md) &gt; [openInNewTab](./kibana-plugin-core-public.navigatetoappoptions.openinnewtab.md)
+
+## NavigateToAppOptions.openInNewTab property
+
+if true, will open the app in new tab, will share session information via window.open if base
+
+<b>Signature:</b>
+
+```typescript
+openInNewTab?: boolean;
+```

docs/development/core/server/kibana-plugin-core-server.cspconfig.disableembedding.md

@@ -0,0 +1,11 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-server](./kibana-plugin-core-server.md) &gt; [CspConfig](./kibana-plugin-core-server.cspconfig.md) &gt; [disableEmbedding](./kibana-plugin-core-server.cspconfig.disableembedding.md)
+
+## CspConfig.disableEmbedding property
+
+<b>Signature:</b>
+
+```typescript
+readonly disableEmbedding: boolean;
+```

docs/development/core/server/kibana-plugin-core-server.cspconfig.md

@@ -21,6 +21,7 @@ The constructor for this class is marked as internal. Third-party code should no
 | Property | Modifiers | Type | Description |
 | --- | --- | --- | --- |
 | [DEFAULT](./kibana-plugin-core-server.cspconfig.default.md) | <code>static</code> | <code>CspConfig</code> | |
+| [disableEmbedding](./kibana-plugin-core-server.cspconfig.disableembedding.md) | | <code>boolean</code> | |
 | [header](./kibana-plugin-core-server.cspconfig.header.md) | | <code>string</code> | |
 | [rules](./kibana-plugin-core-server.cspconfig.rules.md) | | <code>string[]</code> | |
 | [strict](./kibana-plugin-core-server.cspconfig.strict.md) | | <code>boolean</code> | |

docs/development/core/server/kibana-plugin-core-server.icspconfig.disableembedding.md

@@ -0,0 +1,13 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-server](./kibana-plugin-core-server.md) &gt; [ICspConfig](./kibana-plugin-core-server.icspconfig.md) &gt; [disableEmbedding](./kibana-plugin-core-server.icspconfig.disableembedding.md)
+
+## ICspConfig.disableEmbedding property
+
+Whether or not embedding (using iframes) should be allowed by the CSP. If embedding is disabled \*and\* no custom rules have been defined, a restrictive 'frame-ancestors' rule will be added to the default CSP rules.
+
+<b>Signature:</b>
+
+```typescript
+readonly disableEmbedding: boolean;
+```

docs/development/core/server/kibana-plugin-core-server.icspconfig.md

@@ -16,6 +16,7 @@ export interface ICspConfig
 
 | Property | Type | Description |
 | --- | --- | --- |
+| [disableEmbedding](./kibana-plugin-core-server.icspconfig.disableembedding.md) | <code>boolean</code> | Whether or not embedding (using iframes) should be allowed by the CSP. If embedding is disabled \*and\* no custom rules have been defined, a restrictive 'frame-ancestors' rule will be added to the default CSP rules. |
 | [header](./kibana-plugin-core-server.icspconfig.header.md) | <code>string</code> | The CSP rules in a formatted directives string for use in a <code>Content-Security-Policy</code> header. |
 | [rules](./kibana-plugin-core-server.icspconfig.rules.md) | <code>string[]</code> | The CSP rules used for Kibana. |
 | [strict](./kibana-plugin-core-server.icspconfig.strict.md) | <code>boolean</code> | Specify whether browsers that do not support CSP should be able to use Kibana. Use <code>true</code> to block and <code>false</code> to allow. |

docs/development/core/server/kibana-plugin-core-server.makeusagefromschema.md

@@ -0,0 +1,15 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-server](./kibana-plugin-core-server.md) &gt; [MakeUsageFromSchema](./kibana-plugin-core-server.makeusagefromschema.md)
+
+## MakeUsageFromSchema type
+
+List of configuration values that will be exposed to usage collection. If parent node or actual config path is set to `true` then the actual value of these configs will be reoprted. If parent node or actual config path is set to `false` then the config will be reported as \[redacted\].
+
+<b>Signature:</b>
+
+```typescript
+export declare type MakeUsageFromSchema<T> = {
+ [Key in keyof T]?: T[Key] extends Maybe<object[]> ? false : T[Key] extends Maybe<any[]> ? boolean : T[Key] extends Maybe<object> ? MakeUsageFromSchema<T[Key]> | boolean : boolean;
+};
+```

docs/development/core/server/kibana-plugin-core-server.md

@@ -272,6 +272,7 @@ The plugin integrates with the core system via lifecycle events: `setup`<!-- -->
 | [LegacyElasticsearchClientConfig](./kibana-plugin-core-server.legacyelasticsearchclientconfig.md) | |
 | [LifecycleResponseFactory](./kibana-plugin-core-server.lifecycleresponsefactory.md) | Creates an object containing redirection or error response with error details, HTTP headers, and other data transmitted to the client. |
 | [LoggerConfigType](./kibana-plugin-core-server.loggerconfigtype.md) | |
+| [MakeUsageFromSchema](./kibana-plugin-core-server.makeusagefromschema.md) | List of configuration values that will be exposed to usage collection. If parent node or actual config path is set to <code>true</code> then the actual value of these configs will be reoprted. If parent node or actual config path is set to <code>false</code> then the config will be reported as \[redacted\]. |
 | [MetricsServiceStart](./kibana-plugin-core-server.metricsservicestart.md) | APIs to retrieves metrics gathered and exposed by the core platform. |
 | [MIGRATION\_ASSISTANCE\_INDEX\_ACTION](./kibana-plugin-core-server.migration_assistance_index_action.md) | |
 | [MIGRATION\_DEPRECATION\_LEVEL](./kibana-plugin-core-server.migration_deprecation_level.md) | |

docs/development/core/server/kibana-plugin-core-server.pluginconfigdescriptor.exposetousage.md

@@ -0,0 +1,17 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-server](./kibana-plugin-core-server.md) &gt; [PluginConfigDescriptor](./kibana-plugin-core-server.pluginconfigdescriptor.md) &gt; [exposeToUsage](./kibana-plugin-core-server.pluginconfigdescriptor.exposetousage.md)
+
+## PluginConfigDescriptor.exposeToUsage property
+
+Expose non-default configs to usage collection to be sent via telemetry. set a config to `true` to report the actual changed config value. set a config to `false` to report the changed config value as \[redacted\].
+
+All changed configs except booleans and numbers will be reported as \[redacted\] unless otherwise specified.
+
+[MakeUsageFromSchema](./kibana-plugin-core-server.makeusagefromschema.md)
+
+<b>Signature:</b>
+
+```typescript
+exposeToUsage?: MakeUsageFromSchema<T>;
+```

docs/development/core/server/kibana-plugin-core-server.pluginconfigdescriptor.md

@@ -46,5 +46,6 @@ export const config: PluginConfigDescriptor<ConfigType> = {
 | --- | --- | --- |
 | [deprecations](./kibana-plugin-core-server.pluginconfigdescriptor.deprecations.md) | <code>ConfigDeprecationProvider</code> | Provider for the to apply to the plugin configuration. |
 | [exposeToBrowser](./kibana-plugin-core-server.pluginconfigdescriptor.exposetobrowser.md) | <code>{</code><br/><code> [P in keyof T]?: boolean;</code><br/><code> }</code> | List of configuration properties that will be available on the client-side plugin. |
+| [exposeToUsage](./kibana-plugin-core-server.pluginconfigdescriptor.exposetousage.md) | <code>MakeUsageFromSchema&lt;T&gt;</code> | Expose non-default configs to usage collection to be sent via telemetry. set a config to <code>true</code> to report the actual changed config value. set a config to <code>false</code> to report the changed config value as \[redacted\].<!-- -->All changed configs except booleans and numbers will be reported as \[redacted\] unless otherwise specified.[MakeUsageFromSchema](./kibana-plugin-core-server.makeusagefromschema.md) |
 | [schema](./kibana-plugin-core-server.pluginconfigdescriptor.schema.md) | <code>PluginConfigSchema&lt;T&gt;</code> | Schema to use to validate the plugin configuration.[PluginConfigSchema](./kibana-plugin-core-server.pluginconfigschema.md) |
 

docs/development/core/server/kibana-plugin-core-server.routeconfigoptionsbody.maxbytes.md

@@ -6,7 +6,7 @@
 
 Limits the size of incoming payloads to the specified byte count. Allowing very large payloads may cause the server to run out of memory.
 
-Default value: The one set in the kibana.yml config file under the parameter `server.maxPayloadBytes`<!-- -->.
+Default value: The one set in the kibana.yml config file under the parameter `server.maxPayload`<!-- -->.
 
 <b>Signature:</b>
 

docs/development/core/server/kibana-plugin-core-server.routeconfigoptionsbody.md

@@ -17,7 +17,7 @@ export interface RouteConfigOptionsBody
 | Property | Type | Description |
 | --- | --- | --- |
 | [accepts](./kibana-plugin-core-server.routeconfigoptionsbody.accepts.md) | <code>RouteContentType &#124; RouteContentType[] &#124; string &#124; string[]</code> | A string or an array of strings with the allowed mime types for the endpoint. Use this settings to limit the set of allowed mime types. Note that allowing additional mime types not listed above will not enable them to be parsed, and if parse is true, the request will result in an error response.<!-- -->Default value: allows parsing of the following mime types: \* application/json \* application/\*+json \* application/octet-stream \* application/x-www-form-urlencoded \* multipart/form-data \* text/\* |
-| [maxBytes](./kibana-plugin-core-server.routeconfigoptionsbody.maxbytes.md) | <code>number</code> | Limits the size of incoming payloads to the specified byte count. Allowing very large payloads may cause the server to run out of memory.<!-- -->Default value: The one set in the kibana.yml config file under the parameter <code>server.maxPayloadBytes</code>. |
+| [maxBytes](./kibana-plugin-core-server.routeconfigoptionsbody.maxbytes.md) | <code>number</code> | Limits the size of incoming payloads to the specified byte count. Allowing very large payloads may cause the server to run out of memory.<!-- -->Default value: The one set in the kibana.yml config file under the parameter <code>server.maxPayload</code>. |
 | [output](./kibana-plugin-core-server.routeconfigoptionsbody.output.md) | <code>typeof validBodyOutput[number]</code> | The processed payload format. The value must be one of: \* 'data' - the incoming payload is read fully into memory. If parse is true, the payload is parsed (JSON, form-decoded, multipart) based on the 'Content-Type' header. If parse is false, a raw Buffer is returned. \* 'stream' - the incoming payload is made available via a Stream.Readable interface. If the payload is 'multipart/form-data' and parse is true, field values are presented as text while files are provided as streams. File streams from a 'multipart/form-data' upload will also have a hapi property containing the filename and headers properties. Note that payload streams for multipart payloads are a synthetic interface created on top of the entire multipart content loaded into memory. To avoid loading large multipart payloads into memory, set parse to false and handle the multipart payload in the handler using a streaming parser (e.g. pez).<!-- -->Default value: 'data', unless no validation.body is provided in the route definition. In that case the default is 'stream' to alleviate memory pressure. |
 | [parse](./kibana-plugin-core-server.routeconfigoptionsbody.parse.md) | <code>boolean &#124; 'gunzip'</code> | Determines if the incoming payload is processed or presented raw. Available values: \* true - if the request 'Content-Type' matches the allowed mime types set by allow (for the whole payload as well as parts), the payload is converted into an object when possible. If the format is unknown, a Bad Request (400) error response is sent. Any known content encoding is decoded. \* false - the raw payload is returned unmodified. \* 'gunzip' - the raw payload is returned unmodified after any known content encoding is decoded.<!-- -->Default value: true, unless no validation.body is provided in the route definition. In that case the default is false to alleviate memory pressure. |
 

docs/development/core/server/kibana-plugin-core-server.savedobjectsmigrationlogger.error.md

@@ -7,5 +7,5 @@
 <b>Signature:</b>
 
 ```typescript
-error: (msg: string, meta: LogMeta) => void;
+error: <Meta extends LogMeta = LogMeta>(msg: string, meta: Meta) => void;
 ```

docs/development/core/server/kibana-plugin-core-server.savedobjectsmigrationlogger.md

@@ -16,7 +16,7 @@ export interface SavedObjectsMigrationLogger
 | Property | Type | Description |
 | --- | --- | --- |
 | [debug](./kibana-plugin-core-server.savedobjectsmigrationlogger.debug.md) | <code>(msg: string) =&gt; void</code> | |
-| [error](./kibana-plugin-core-server.savedobjectsmigrationlogger.error.md) | <code>(msg: string, meta: LogMeta) =&gt; void</code> | |
+| [error](./kibana-plugin-core-server.savedobjectsmigrationlogger.error.md) | <code>&lt;Meta extends LogMeta = LogMeta&gt;(msg: string, meta: Meta) =&gt; void</code> | |
 | [info](./kibana-plugin-core-server.savedobjectsmigrationlogger.info.md) | <code>(msg: string) =&gt; void</code> | |
 | [warn](./kibana-plugin-core-server.savedobjectsmigrationlogger.warn.md) | <code>(msg: string) =&gt; void</code> | |
 | [warning](./kibana-plugin-core-server.savedobjectsmigrationlogger.warning.md) | <code>(msg: string) =&gt; void</code> | |

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.esquerysortvalue.md

@@ -7,5 +7,5 @@
 <b>Signature:</b>
 
 ```typescript
-export declare type EsQuerySortValue = Record<string, SortDirection | SortDirectionNumeric>;
+export declare type EsQuerySortValue = Record<string, SortDirection | SortDirectionNumeric | SortDirectionFormat>;
 ```

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.ieserror.md

@@ -0,0 +1,11 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [IEsError](./kibana-plugin-plugins-data-public.ieserror.md)
+
+## IEsError type
+
+<b>Signature:</b>
+
+```typescript
+export declare type IEsError = KibanaServerError<IEsErrorAttributes>;
+```

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.iseserror.md

@@ -0,0 +1,24 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-public](./kibana-plugin-plugins-data-public.md) &gt; [isEsError](./kibana-plugin-plugins-data-public.iseserror.md)
+
+## isEsError() function
+
+Checks if a given errors originated from Elasticsearch. Those params are assigned to the attributes property of an error.
+
+<b>Signature:</b>
+
+```typescript
+export declare function isEsError(e: any): e is IEsError;
+```
+
+## Parameters
+
+| Parameter | Type | Description |
+| --- | --- | --- |
+| e | <code>any</code> | |
+
+<b>Returns:</b>
+
+`e is IEsError`
+

docs/development/plugins/data/public/kibana-plugin-plugins-data-public.md

@@ -46,6 +46,7 @@
 | [getEsPreference(uiSettings, sessionId)](./kibana-plugin-plugins-data-public.getespreference.md) | |
 | [getSearchParamsFromRequest(searchRequest, dependencies)](./kibana-plugin-plugins-data-public.getsearchparamsfromrequest.md) | |
 | [getTime(indexPattern, timeRange, options)](./kibana-plugin-plugins-data-public.gettime.md) | |
+| [isEsError(e)](./kibana-plugin-plugins-data-public.iseserror.md) | Checks if a given errors originated from Elasticsearch. Those params are assigned to the attributes property of an error. |
 | [plugin(initializerContext)](./kibana-plugin-plugins-data-public.plugin.md) | |
 | [waitUntilNextSessionCompletes$(sessionService, { waitForIdle })](./kibana-plugin-plugins-data-public.waituntilnextsessioncompletes_.md) | Creates an observable that emits when next search session completes. This utility is helpful to use in the application to delay some tasks until next session completes. |
 
@@ -86,6 +87,7 @@
 | [QuerySuggestionField](./kibana-plugin-plugins-data-public.querysuggestionfield.md) | \* |
 | [QuerySuggestionGetFnArgs](./kibana-plugin-plugins-data-public.querysuggestiongetfnargs.md) | \* |
 | [RangeFilterParams](./kibana-plugin-plugins-data-public.rangefilterparams.md) | |
+| [Reason](./kibana-plugin-plugins-data-public.reason.md) | |
 | [RefreshInterval](./kibana-plugin-plugins-data-public.refreshinterval.md) | |
 | [SavedQuery](./kibana-plugin-plugins-data-public.savedquery.md) | |
 | [SavedQueryService](./kibana-plugin-plugins-data-public.savedqueryservice.md) | |
@@ -161,6 +163,7 @@
 | [Filter](./kibana-plugin-plugins-data-public.filter.md) | |
 | [IAggConfig](./kibana-plugin-plugins-data-public.iaggconfig.md) | AggConfig This class represents an aggregation, which is displayed in the left-hand nav of the Visualize app. |
 | [IAggType](./kibana-plugin-plugins-data-public.iaggtype.md) | |
+| [IEsError](./kibana-plugin-plugins-data-public.ieserror.md) | |
 | [IEsSearchResponse](./kibana-plugin-plugins-data-public.iessearchresponse.md) | |
 | [IFieldFormat](./kibana-plugin-plugins-data-public.ifieldformat.md) | |
 | [IFieldFormatsRegistry](./kibana-plugin-plugins-data-public.ifieldformatsregistry.md) | |