Merge remote-tracking branch 'upstream/master' into add-trap-to-sigin…

…t-on-precommit-hook-script

.i18nrc.json

@@ -17,6 +17,7 @@
  "kbn": "src/legacy/core_plugins/kibana",
  "kbnDocViews": "src/legacy/core_plugins/kbn_doc_views",
  "kbnVislibVisTypes": "src/legacy/core_plugins/kbn_vislib_vis_types",
+ "management": "src/legacy/core_plugins/management",
  "kibana_react": "src/legacy/core_plugins/kibana_react",
  "kibana-react": "src/plugins/kibana_react",
  "kibana_utils": "src/plugins/kibana_utils",

NOTICE.txt

@@ -186,32 +186,6 @@ LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
 NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
 SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
----
-This product includes code that is based on facebookincubator/idx, which was
-available under a "MIT" license.
-
-MIT License
-
-Copyright (c) 2013-present, Facebook, Inc.
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
-
 ---
 This product includes code that was extracted from [email protected].
 Original license:

docs/developer/core/development-functional-tests.asciidoc

@@ -282,7 +282,7 @@ The `FunctionalTestRunner` comes with three built-in services:
 * Source: {blob}src/functional_test_runner/lib/lifecycle.ts[src/functional_test_runner/lib/lifecycle.ts]
 * Designed primary for use in services
 * Exposes lifecycle events for basic coordination. Handlers can return a promise and resolve/fail asynchronously
-* Phases include: `beforeLoadTests`, `beforeTests`, `beforeEachTest`, `cleanup`, `phaseStart`, `phaseEnd`
+* Phases include: `beforeLoadTests`, `beforeTests`, `beforeEachTest`, `cleanup`
 
 [float]
 ===== Kibana Services

docs/development/core/public/kibana-plugin-public.appmountcontext.core.md

@@ -17,6 +17,7 @@ core: {
  i18n: I18nStart;
  notifications: NotificationsStart;
  overlays: OverlayStart;
+ savedObjects: SavedObjectsStart;
  uiSettings: IUiSettingsClient;
  injectedMetadata: {
  getInjectedVar: (name: string, defaultValue?: any) => unknown;

docs/development/core/public/kibana-plugin-public.appmountcontext.md

@@ -16,5 +16,5 @@ export interface AppMountContext
 
 | Property | Type | Description |
 | --- | --- | --- |
-| [core](./kibana-plugin-public.appmountcontext.core.md) | <code>{</code><br/><code> application: Pick&lt;ApplicationStart, 'capabilities' &#124; 'navigateToApp'&gt;;</code><br/><code> chrome: ChromeStart;</code><br/><code> docLinks: DocLinksStart;</code><br/><code> http: HttpStart;</code><br/><code> i18n: I18nStart;</code><br/><code> notifications: NotificationsStart;</code><br/><code> overlays: OverlayStart;</code><br/><code> uiSettings: IUiSettingsClient;</code><br/><code> injectedMetadata: {</code><br/><code> getInjectedVar: (name: string, defaultValue?: any) =&gt; unknown;</code><br/><code> };</code><br/><code> }</code> | Core service APIs available to mounted applications. |
+| [core](./kibana-plugin-public.appmountcontext.core.md) | <code>{</code><br/><code> application: Pick&lt;ApplicationStart, 'capabilities' &#124; 'navigateToApp'&gt;;</code><br/><code> chrome: ChromeStart;</code><br/><code> docLinks: DocLinksStart;</code><br/><code> http: HttpStart;</code><br/><code> i18n: I18nStart;</code><br/><code> notifications: NotificationsStart;</code><br/><code> overlays: OverlayStart;</code><br/><code> savedObjects: SavedObjectsStart;</code><br/><code> uiSettings: IUiSettingsClient;</code><br/><code> injectedMetadata: {</code><br/><code> getInjectedVar: (name: string, defaultValue?: any) =&gt; unknown;</code><br/><code> };</code><br/><code> }</code> | Core service APIs available to mounted applications. |
 

docs/management/field-formatters/url-formatter.asciidoc

@@ -4,6 +4,8 @@ The `Url` field formatter can take on the following types:
 * The *Image* type can be used to specify an image directory where a specified image is located.
 * The *Audio* type can be used to specify an audio directory where a specified audio file is located.
 
+For an *Image* type you can specify width and height attributes. These will be used to set the max width / max height of the image, while keeping the aspect ratio. Image will not be upscaled if it's smaller than the provided size parameters.
+
 You can customize either type of URL field formats with templates. A _URL template_ enables you to add specific values
 to a partial URL. Use the string `{{value}}` to add the contents of the field to a fixed URL.
 

docs/maps/connect-to-ems.asciidoc

@@ -13,11 +13,20 @@ EMS requests are made to the following domains:
 * vector.maps.elastic.co
 
 **Elastic Maps** makes requests directly from the browser to EMS.
-To proxy EMS requests through the Kibana server, set `map.proxyElasticMapsServiceInMaps` to `true` in your <<settings, kibana.yml>> file.
+
+[float]
+=== Connect to Elastic Maps Service from an internal network
+
+To connect to EMS when your Kibana server and browser are in an internal network:
+
+. Set `map.proxyElasticMapsServiceInMaps` to `true` in your <<settings, kibana.yml>> file to proxy EMS requests through the Kibana server.
+. Update your firewall rules to whitelist connections from your Kibana server to the EMS domains listed above.
+
+NOTE: Coordinate map and region map visualizations do not support `map.proxyElasticMapsServiceInMaps` and will not proxy EMS requests through the Kibana server.
 
 
 [float]
-=== Disabling Elastic Maps Service
+=== Disable Elastic Maps Service
 
 You might experience EMS connection issues if your Kibana server or browser are on a private network or
 behind a firewall. If this happens, you can disable the EMS connection to avoid unnecessary EMS requests.

docs/setup/settings.asciidoc

@@ -147,6 +147,36 @@ will default to `true`.
 `logging.quiet:`:: *Default: false* Set the value of this setting to `true` to
 suppress all logging output other than error messages.
 
+`logging.rotate:`:: [experimental] Specifies the options for the logging rotate feature.
+When not defined, all the sub options defaults would be applied.
+The following example shows a valid logging rotate configuration:
++
+--
+ logging.rotate:
+ enabled: true
+ everyBytes: 10485760
+ keepFiles: 10
+--
+
+`logging.rotate.enabled:`:: [experimental] *Default: false* Set the value of this setting to `true` to
+enable log rotation. If you do not have a `logging.dest` set that is different from `stdout`
+that feature would not take any effect.
+
+`logging.rotate.everyBytes:`:: [experimental] *Default: 10485760* The maximum size of a log file (that is `not an exact` limit). After the 
+limit is reached, a new log file is generated. The default size limit is 10485760 (10 MB) and
+this option should be at least greater than 1024.
+
+`logging.rotate.keepFiles:`:: [experimental] *Default: 7* The number of most recent rotated log files to keep 
+on disk. Older files are deleted during log rotation. The default value is 7. The `logging.rotate.keepFiles` 
+option has to be in the range of 2 to 1024 files.
+
+`logging.rotate.pollingInterval:`:: [experimental] *Default: 10000* The number of milliseconds for the polling strategy in case 
+the `logging.rotate.usePolling` is enabled. That option has to be in the range of 5000 to 3600000 milliseconds.
+
+`logging.rotate.usePolling:`:: [experimental] *Default: false* By default we try to understand the best way to monitoring 
+the log file. However, there is some systems where it could not be always accurate. In those cases, if needed, 
+the `polling` method could be used enabling that option.
+
 `logging.silent:`:: *Default: false* Set the value of this setting to `true` to
 suppress all logging output.
 

docs/visualize/most-frequent.asciidoc

@@ -7,20 +7,19 @@ levels of {es} {ref}/search-aggregations-bucket.html[bucket] aggregations.
 
 The most frequently used visualizations include:
 
-* Line, Area and Bar charts
+* Line, area, and bar charts
 * Pie charts
-* Data table
-* Metric visualization
-* Goal and Gauge visualization
+* Data tables
+* Metric, goals, and gauges
 * Heat maps
-* Tag cloud
+* Tag clouds
 
 [float]
 === Configure your visualization
 
-You configure visualizations using the default editor, which is broken into *Metrics* and *Buckets*, and includes a default count
+You configure visualizations using the default editor, which is broken into metrics and buckets, and includes a default count
 metric. Each visualization supports different configurations for what the metrics and buckets
-represent. For example, a Bar chart allows you to add an X-axis:
+represent. For example, a bar chart allows you to add an X-axis:
 
 [role="screenshot"]
 image::images/add-bucket.png["",height=478]

package.json

@@ -88,7 +88,8 @@
  "**/image-diff/gm/debug": "^2.6.9",
  "**/react-dom": "^16.12.0",
  "**/react-test-renderer": "^16.12.0",
- "**/deepmerge": "^4.2.2"
+ "**/deepmerge": "^4.2.2",
+ "**/serialize-javascript": "^2.1.1"
  },
  "workspaces": {
  "packages": [
@@ -112,7 +113,7 @@
  "@elastic/charts": "^14.0.0",
  "@elastic/datemath": "5.0.2",
  "@elastic/ems-client": "1.0.5",
- "@elastic/eui": "16.1.0",
+ "@elastic/eui": "17.0.0",
  "@elastic/filesaver": "1.1.2",
  "@elastic/good": "8.1.1-kibana2",
  "@elastic/numeral": "2.3.3",
@@ -149,6 +150,7 @@
  "cache-loader": "^4.1.0",
  "chalk": "^2.4.2",
  "check-disk-space": "^2.1.0",
+ "chokidar": "3.2.1",
  "color": "1.0.3",
  "commander": "3.0.0",
  "compare-versions": "3.5.1",
@@ -165,6 +167,7 @@
  "encode-uri-query": "1.0.1",
  "execa": "^3.2.0",
  "expiry-js": "0.1.7",
+ "fast-deep-equal": "^3.1.1",
  "file-loader": "4.2.0",
  "font-awesome": "4.7.0",
  "getos": "^3.1.0",
@@ -228,6 +231,7 @@
  "react-resize-detector": "^4.2.0",
  "react-router-dom": "^4.3.1",
  "react-sizeme": "^2.3.6",
+ "react-use": "^13.10.2",
  "reactcss": "1.2.3",
  "redux": "4.0.0",
  "redux-actions": "2.2.1",
@@ -357,8 +361,8 @@
  "@types/uuid": "^3.4.4",
  "@types/vinyl-fs": "^2.4.11",
  "@types/zen-observable": "^0.8.0",
- "@typescript-eslint/eslint-plugin": "^2.9.0",
- "@typescript-eslint/parser": "^2.9.0",
+ "@typescript-eslint/eslint-plugin": "^2.10.0",
+ "@typescript-eslint/parser": "^2.10.0",
  "angular-mocks": "^1.7.8",
  "archiver": "^3.1.1",
  "axe-core": "^3.3.2",
@@ -370,7 +374,6 @@
  "chai": "3.5.0",
  "chance": "1.0.18",
  "cheerio": "0.22.0",
- "chokidar": "3.2.1",
  "chromedriver": "78.0.1",
  "classnames": "2.2.6",
  "dedent": "^0.7.0",

packages/eslint-config-kibana/.eslintrc.js

@@ -28,6 +28,11 @@ module.exports = {
  to: false,
  disallowedMessage: `Don't use 'mkdirp', use the new { recursive: true } option of Fs.mkdir instead`
  },
+ {
+ from: '@kbn/elastic-idx',
+ to: false,
+ disallowedMessage: `Don't use idx(), use optional chaining syntax instead https://ela.st/optchain`
+ },
  {
  from: 'x-pack',
  toRelative: 'x-pack',

packages/eslint-config-kibana/package.json

@@ -15,8 +15,8 @@
  },
  "homepage": "https:/elastic/eslint-config-kibana#readme",
  "peerDependencies": {
- "@typescript-eslint/eslint-plugin": "^2.9.0",
- "@typescript-eslint/parser": "^2.9.0",
+ "@typescript-eslint/eslint-plugin": "^2.10.0",
+ "@typescript-eslint/parser": "^2.10.0",
  "babel-eslint": "^10.0.3",
  "eslint": "^6.5.1",
  "eslint-plugin-babel": "^5.3.0",

packages/kbn-babel-preset/common_preset.js

@@ -35,13 +35,6 @@ const plugins = [
  // Need this since we are using TypeScript 3.7+
  require.resolve('@babel/plugin-proposal-nullish-coalescing-operator'),
 ];
-const isTestEnv = process.env.BABEL_ENV === 'test' || process.env.NODE_ENV === 'test';
-
-// Only load the idx plugin in non-test environments, since it conflicts with
-// Jest's coverage mapping.
-if (!isTestEnv) {
- plugins.push(require.resolve('@kbn/elastic-idx/babel'));
-}
 
 module.exports = {
  presets: [require.resolve('@babel/preset-typescript'), require.resolve('@babel/preset-react')],

packages/kbn-babel-preset/package.json

@@ -12,7 +12,6 @@
  "@babel/preset-env": "^7.5.5",
  "@babel/preset-react": "^7.0.0",
  "@babel/preset-typescript": "^7.3.3",
- "@kbn/elastic-idx": "1.0.0",
  "babel-plugin-add-module-exports": "^1.0.2",
  "babel-plugin-filter-imports": "^3.0.0",
  "babel-plugin-transform-define": "^1.3.1",