Skip to content

Commit

Permalink
Don't throw exception when refreshing fields of an indexpattern (#55836
Browse files Browse the repository at this point in the history
…) (#56031)

* An exception when refreshing fields of an selected index pattern caused Discover to load incompletely
* Add index ID + Title of the index pattern to the error messages in this case
  • Loading branch information
kertal authored Jan 27, 2020
1 parent 7a53f8b commit b1eaa26
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -581,10 +581,13 @@ export class IndexPattern implements IIndexPattern {

toasts.addError(err, {
title: i18n.translate('data.indexPatterns.fetchFieldErrorTitle', {
defaultMessage: 'Error fetching fields',
defaultMessage: 'Error fetching fields for index pattern {title} (ID: {id})',
values: {
id: this.id,
title: this.title,
},
}),
});
throw err;
});
}

Expand Down
3 changes: 1 addition & 2 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,6 @@
"data.filter.options.pinAllFiltersButtonLabel": "すべてピン付け",
"data.filter.options.unpinAllFiltersButtonLabel": "すべてのピンを外す",
"data.filter.searchBar.changeAllFiltersTitle": "すべてのフィルターの変更",
"data.indexPatterns.fetchFieldErrorTitle": "フィールドの取得中にエラーが発生",
"data.indexPatterns.unableWriteLabel": "インデックスパターンを書き込めません!このインデックスパターンへの最新の変更を取得するには、ページを更新してください。",
"data.indexPatterns.unknownFieldErrorMessage": "インデックスパターン「{title}」のフィールド「{name}」が不明なフィールドタイプを使用しています。",
"data.indexPatterns.unknownFieldHeader": "不明なフィールドタイプ {type}",
Expand Down Expand Up @@ -13205,4 +13204,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "フィールドを選択してください。",
"xpack.watcher.watcherDescription": "アラートの作成、管理、監視によりデータへの変更を検知します。"
}
}
}
3 changes: 1 addition & 2 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,6 @@
"data.filter.options.pinAllFiltersButtonLabel": "全部固定",
"data.filter.options.unpinAllFiltersButtonLabel": "全部取消固定",
"data.filter.searchBar.changeAllFiltersTitle": "更改所有筛选",
"data.indexPatterns.fetchFieldErrorTitle": "提取字段时出错",
"data.indexPatterns.unableWriteLabel": "无法写入索引模式!请刷新页面以获取此索引模式的最新更改。",
"data.indexPatterns.unknownFieldErrorMessage": "indexPattern “{title}” 中的字段 “{name}” 使用未知字段类型。",
"data.indexPatterns.unknownFieldHeader": "未知字段类型 {type}",
Expand Down Expand Up @@ -13204,4 +13203,4 @@
"xpack.watcher.watchEdit.thresholdWatchExpression.aggType.fieldIsRequiredValidationMessage": "此字段必填。",
"xpack.watcher.watcherDescription": "通过创建、管理和监测警报来检测数据中的更改。"
}
}
}

0 comments on commit b1eaa26

Please sign in to comment.