Fix edit button label

elastic · Oct 27, 2022 · ba705a9 · ba705a9
1 parent b9105f8
commit ba705a9
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 11 deletions.
diff --git a/src/plugins/embeddable/public/lib/panel/embeddable_panel_error.tsx b/src/plugins/embeddable/public/lib/panel/embeddable_panel_error.tsx
@@ -33,20 +33,20 @@ export function EmbeddablePanelError({
  [editPanelAction, embeddable, isEditable]
  );
 
- const title = embeddable.getTitle();
- const actionDisplayName = useMemo(
+ const label = useMemo(
  () => editPanelAction?.getDisplayName({ embeddable }),
  [editPanelAction, embeddable]
  );
- const label = useMemo(
+ const title = useMemo(() => embeddable.getTitle(), [embeddable]);
+ const ariaLabel = useMemo(
  () =>
  !title
- ? actionDisplayName
+ ? label
  : i18n.translate('embeddableApi.panel.editPanel.displayName', {
  defaultMessage: 'Edit {value}',
  values: { value: title },
  }),
- [title, actionDisplayName]
+ [label, title]
  );
 
  useEffect(() => {
@@ -77,7 +77,7 @@ export function EmbeddablePanelError({
  layout="vertical"
  actions={
  isEditable && (
- <EuiButtonEmpty onClick={handleErrorClick} size="s">
+ <EuiButtonEmpty aria-label={ariaLabel} onClick={handleErrorClick} size="s">
  {label}
  </EuiButtonEmpty>
  )

diff --git a/src/plugins/visualizations/public/embeddable/visualize_embeddable_factory.tsx b/src/plugins/visualizations/public/embeddable/visualize_embeddable_factory.tsx
@@ -134,7 +134,7 @@ export class VisualizeEmbeddableFactory
 
  public getDisplayName() {
  return i18n.translate('visualizations.displayName', {
- defaultMessage: 'Visualization',
+ defaultMessage: 'visualization',
  });
  }
 

diff --git a/x-pack/plugins/lens/public/embeddable/embeddable_factory.ts b/x-pack/plugins/lens/public/embeddable/embeddable_factory.ts
@@ -79,7 +79,7 @@ export class EmbeddableFactory implements EmbeddableFactoryDefinition {
 
  getDisplayName() {
  return i18n.translate('xpack.lens.embeddableDisplayName', {
- defaultMessage: 'lens',
+ defaultMessage: 'Lens',
  });
  }
 

diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json
@@ -6141,7 +6141,7 @@
  "visualizations.deprecatedTag": "Déclassé",
  "visualizations.disabledLabVisualizationLink": "Lire la documentation",
  "visualizations.disabledLabVisualizationMessage": "Veuillez activer le mode lab dans les paramètres avancés pour consulter les visualisations lab.",
- "visualizations.displayName": "Visualisation",
+ "visualizations.displayName": "visualisation",
  "visualizations.editor.createBreadcrumb": "Créer",
  "visualizations.editor.defaultEditBreadcrumbText": "Modifier la visualisation",
  "visualizations.embeddable.inspectorTitle": "Inspecteur",
@@ -17452,7 +17452,7 @@
  "xpack.lens.embeddable.missingTimeRangeParam.longMessage": "La propriété timeRange est requise pour cette configuration.",
  "xpack.lens.embeddable.missingTimeRangeParam.shortMessage": "Propriété timeRange manquante",
  "xpack.lens.embeddable.moreErrors": "Effectuez des modifications dans l'éditeur Lens pour afficher plus d'erreurs",
- "xpack.lens.embeddableDisplayName": "lens",
+ "xpack.lens.embeddableDisplayName": "Lens",
  "xpack.lens.endValue.nearest": "La plus proche",
  "xpack.lens.endValue.none": "Masquer",
  "xpack.lens.endValue.zero": "Zéro",

diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
@@ -17460,7 +17460,7 @@
  "xpack.lens.embeddable.missingTimeRangeParam.longMessage": "给定配置需要包含 timeRange 属性",
  "xpack.lens.embeddable.missingTimeRangeParam.shortMessage": "缺少 timeRange 属性",
  "xpack.lens.embeddable.moreErrors": "在 Lens 编辑器中编辑以查看更多错误",
- "xpack.lens.embeddableDisplayName": "lens",
+ "xpack.lens.embeddableDisplayName": "Lens",
  "xpack.lens.endValue.nearest": "最近",
  "xpack.lens.endValue.none": "隐藏",
  "xpack.lens.endValue.zero": "零",