[build_ts_refs] improve caches, allow building a subset of projects (#…

…107981) * [build_ts_refs] improve caches, allow building a subset of projects * cleanup project def script and update refs in type check script * rename browser_bazel config to avoid kebab-case * remove execInProjects() helper * list references for tsconfig.types.json for api-extractor workload * disable composite features of tsconfig.types.json for api-extractor * set declaration: true to avoid weird debug error * fix jest tests Co-authored-by: spalger <[email protected]>
elastic · Aug 11, 2021 · c0395c9 · c0395c9
1 parent 6ed4b4f
commit c0395c9
Show file tree

Hide file tree

Showing 338 changed files with 1,165 additions and 1,284 deletions.
diff --git a/.gitignore b/.gitignore
@@ -75,6 +75,9 @@ report.asciidoc
 # TS incremental build cache
 *.tsbuildinfo
 
+# Automatically generated and user-modifiable
+/tsconfig.refs.json
+
 # Yarn local mirror content
 .yarn-local-mirror
 

diff --git a/BUILD.bazel b/BUILD.bazel
@@ -3,7 +3,9 @@
 exports_files(
  [
  "tsconfig.base.json",
+ "tsconfig.bazel.json",
  "tsconfig.browser.json",
+ "tsconfig.browser_bazel.json",
  "tsconfig.json",
  "package.json"
  ],

diff --git a/docs/developer/best-practices/typescript.asciidoc b/docs/developer/best-practices/typescript.asciidoc
@@ -41,7 +41,6 @@ Additionally, in order to migrate into project refs, you also need to make sure
 {
  "extends": "../../../tsconfig.base.json",
  "compilerOptions": {
- "composite": true,
  "outDir": "./target/types",
  "emitDeclarationOnly": true,
  "declaration": true,

diff --git a/examples/bfetch_explorer/tsconfig.json b/examples/bfetch_explorer/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types",
  },
  "include": [
  "index.ts",
@@ -14,6 +13,8 @@
  "exclude": [],
  "references": [
  { "path": "../../src/core/tsconfig.json" },
+ { "path": "../developer_examples/tsconfig.json" },
+ { "path": "../../src/plugins/bfetch/tsconfig.json" },
  { "path": "../../src/plugins/kibana_react/tsconfig.json" },
  ]
 }
diff --git a/examples/dashboard_embeddable_examples/tsconfig.json b/examples/dashboard_embeddable_examples/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -13,6 +12,11 @@
  ],
  "exclude": [],
  "references": [
- { "path": "../../src/core/tsconfig.json" }
+ { "path": "../../src/core/tsconfig.json" },
+ { "path": "../../src/plugins/dashboard/tsconfig.json" },
+ { "path": "../../src/plugins/embeddable/tsconfig.json" },
+ { "path": "../../src/plugins/es_ui_shared/tsconfig.json" },
+ { "path": "../embeddable_examples/tsconfig.json" },
+ { "path": "../developer_examples/tsconfig.json" },
  ]
 }
diff --git a/examples/developer_examples/tsconfig.json b/examples/developer_examples/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",

diff --git a/examples/embeddable_examples/tsconfig.json b/examples/embeddable_examples/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -15,6 +14,12 @@
  "exclude": [],
  "references": [
  { "path": "../../src/core/tsconfig.json" },
+ { "path": "../../src/plugins/kibana_utils/tsconfig.json" },
  { "path": "../../src/plugins/kibana_react/tsconfig.json" },
+ { "path": "../../src/plugins/ui_actions/tsconfig.json" },
+ { "path": "../../src/plugins/embeddable/tsconfig.json" },
+ { "path": "../../src/plugins/dashboard/tsconfig.json" },
+ { "path": "../../src/plugins/saved_objects/tsconfig.json" },
+ { "path": "../../src/plugins/presentation_util/tsconfig.json" },
  ]
 }
diff --git a/examples/embeddable_explorer/tsconfig.json b/examples/embeddable_explorer/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -14,6 +13,10 @@
  "exclude": [],
  "references": [
  { "path": "../../src/core/tsconfig.json" },
- { "path": "../../src/plugins/inspector/tsconfig.json" }
+ { "path": "../../src/plugins/embeddable/tsconfig.json" },
+ { "path": "../../src/plugins/ui_actions/tsconfig.json" },
+ { "path": "../../src/plugins/inspector/tsconfig.json" },
+ { "path": "../embeddable_examples/tsconfig.json" },
+ { "path": "../developer_examples/tsconfig.json" },
  ]
 }
diff --git a/examples/expressions_explorer/tsconfig.json b/examples/expressions_explorer/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -14,5 +13,9 @@
  "references": [
  { "path": "../../src/core/tsconfig.json" },
  { "path": "../../src/plugins/kibana_react/tsconfig.json" },
+ { "path": "../../src/plugins/expressions/tsconfig.json" },
+ { "path": "../../src/plugins/ui_actions/tsconfig.json" },
+ { "path": "../../src/plugins/inspector/tsconfig.json" },
+ { "path": "../developer_examples/tsconfig.json" },
  ]
 }
diff --git a/examples/hello_world/tsconfig.json b/examples/hello_world/tsconfig.json
@@ -12,5 +12,9 @@
  "server/**/*.ts",
  "../../typings/**/*"
  ],
- "exclude": []
+ "exclude": [],
+ "references": [
+ { "path": "../../src/core/tsconfig.json" },
+ { "path": "../developer_examples/tsconfig.json" },
+ ]
 }
diff --git a/examples/index_pattern_field_editor_example/tsconfig.json b/examples/index_pattern_field_editor_example/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -14,5 +13,8 @@
  "references": [
  { "path": "../../src/core/tsconfig.json" },
  { "path": "../../src/plugins/kibana_react/tsconfig.json" },
+ { "path": "../../src/plugins/data/tsconfig.json" },
+ { "path": "../../src/plugins/index_pattern_field_editor/tsconfig.json" },
+ { "path": "../developer_examples/tsconfig.json" },
  ]
-}
+}
diff --git a/examples/locator_examples/tsconfig.json b/examples/locator_examples/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -13,6 +12,7 @@
  ],
  "exclude": [],
  "references": [
- { "path": "../../src/core/tsconfig.json" }
+ { "path": "../../src/core/tsconfig.json" },
+ { "path": "../../src/plugins/share/tsconfig.json" },
  ]
 }
diff --git a/examples/locator_explorer/tsconfig.json b/examples/locator_explorer/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -13,6 +12,9 @@
  ],
  "exclude": [],
  "references": [
- { "path": "../../src/core/tsconfig.json" }
+ { "path": "../../src/core/tsconfig.json" },
+ { "path": "../../src/plugins/share/tsconfig.json" },
+ { "path": "../locator_examples/tsconfig.json" },
+ { "path": "../developer_examples/tsconfig.json" },
  ]
 }
diff --git a/examples/preboot_example/tsconfig.json b/examples/preboot_example/tsconfig.json
@@ -1,7 +1,6 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "composite": true,
  "outDir": "./target/types",
  "emitDeclarationOnly": true,
  "declaration": true,

diff --git a/examples/routing_example/tsconfig.json b/examples/routing_example/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -14,6 +13,7 @@
  ],
  "exclude": [],
  "references": [
- { "path": "../../src/core/tsconfig.json" }
+ { "path": "../../src/core/tsconfig.json" },
+ { "path": "../developer_examples/tsconfig.json" },
  ]
 }
diff --git a/examples/screenshot_mode_example/tsconfig.json b/examples/screenshot_mode_example/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -13,5 +12,11 @@
  "../../typings/**/*"
  ],
  "exclude": [],
- "references": [{ "path": "../../src/core/tsconfig.json" }]
+ "references": [
+ { "path": "../../src/core/tsconfig.json" },
+ { "path": "../../src/plugins/navigation/tsconfig.json" },
+ { "path": "../../src/plugins/screenshot_mode/tsconfig.json" },
+ { "path": "../../src/plugins/usage_collection/tsconfig.json" },
+ { "path": "../developer_examples/tsconfig.json" },
+ ]
 }
diff --git a/examples/search_examples/tsconfig.json b/examples/search_examples/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -14,6 +13,12 @@
  ],
  "exclude": [],
  "references": [
- { "path": "../../src/core/tsconfig.json" }
+ { "path": "../../src/core/tsconfig.json" },
+ { "path": "../../src/plugins/data/tsconfig.json" },
+ { "path": "../../src/plugins/kibana_utils/tsconfig.json" },
+ { "path": "../../src/plugins/kibana_react/tsconfig.json" },
+ { "path": "../../src/plugins/navigation/tsconfig.json" },
+ { "path": "../../src/plugins/share/tsconfig.json" },
+ { "path": "../developer_examples/tsconfig.json" },
  ]
 }
diff --git a/examples/state_containers_examples/tsconfig.json b/examples/state_containers_examples/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -17,5 +16,8 @@
  { "path": "../../src/core/tsconfig.json" },
  { "path": "../../src/plugins/kibana_utils/tsconfig.json" },
  { "path": "../../src/plugins/kibana_react/tsconfig.json" },
+ { "path": "../../src/plugins/navigation/tsconfig.json" },
+ { "path": "../../src/plugins/data/tsconfig.json" },
+ { "path": "../developer_examples/tsconfig.json" },
  ]
 }
diff --git a/examples/ui_action_examples/tsconfig.json b/examples/ui_action_examples/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -13,7 +12,7 @@
  ],
  "exclude": [],
  "references": [
- { "path": "../../src/core/tsconfig.json" },
  { "path": "../../src/plugins/kibana_react/tsconfig.json" },
+ { "path": "../../src/plugins/ui_actions/tsconfig.json" },
  ]
 }
diff --git a/examples/ui_actions_explorer/tsconfig.json b/examples/ui_actions_explorer/tsconfig.json
@@ -1,8 +1,7 @@
 {
  "extends": "../../tsconfig.base.json",
  "compilerOptions": {
- "outDir": "./target",
- "skipLibCheck": true
+ "outDir": "./target/types"
  },
  "include": [
  "index.ts",
@@ -14,5 +13,8 @@
  "references": [
  { "path": "../../src/core/tsconfig.json" },
  { "path": "../../src/plugins/kibana_react/tsconfig.json" },
+ { "path": "../../src/plugins/ui_actions/tsconfig.json" },
+ { "path": "../ui_action_examples/tsconfig.json" },
+ { "path": "../developer_examples/tsconfig.json" },
  ]
 }
diff --git a/packages/elastic-datemath/BUILD.bazel b/packages/elastic-datemath/BUILD.bazel
@@ -39,6 +39,7 @@ ts_config(
  src = "tsconfig.json",
  deps = [
  "//:tsconfig.base.json",
+ "//:tsconfig.bazel.json",
  ],
 )
 
@@ -50,7 +51,6 @@ ts_project(
  declaration = True,
  declaration_map = True,
  emit_declaration_only = True,
- incremental = False,
  out_dir = "target_types",
  source_map = True,
  root_dir = "src",

diff --git a/packages/elastic-datemath/tsconfig.json b/packages/elastic-datemath/tsconfig.json
@@ -1,10 +1,9 @@
 {
- "extends": "../../tsconfig.base.json",
+ "extends": "../../tsconfig.bazel.json",
  "compilerOptions": {
  "declaration": true,
  "declarationMap": true,
  "emitDeclarationOnly": true,
- "incremental": false,
  "outDir": "target_types",
  "rootDir": "src",
  "sourceMap": true,

diff --git a/packages/elastic-safer-lodash-set/tsconfig.json b/packages/elastic-safer-lodash-set/tsconfig.json
@@ -1,8 +1,6 @@
 {
- "extends": "../../tsconfig.base.json",
- "compilerOptions": {
- "incremental": false,
- },
+ "extends": "../../tsconfig.bazel.json",
+ "compilerOptions": {},
  "include": [
  "**/*",
  ],