fix never working hasChartSwitchWarning method

elastic · Aug 6, 2020 · e20e8c6 · e20e8c6
1 parent 2383e5b
commit e20e8c6
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/x-pack/test/functional/apps/lens/smokescreen.ts b/x-pack/test/functional/apps/lens/smokescreen.ts
@@ -77,7 +77,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
  await PageObjects.lens.goToTimeRange();
  await PageObjects.lens.assertMetric('Maximum of bytes', '19,986');
  await PageObjects.lens.switchToVisualization('lnsDatatable');
- expect(await PageObjects.lens.getDatatableThText()).to.eql('Maximum of bytes');
+ expect(await PageObjects.lens.getDatatableHeaderText()).to.eql('Maximum of bytes');
  expect(await PageObjects.lens.getDatatableCellText(0, 0)).to.eql('19,986');
  await PageObjects.lens.switchToVisualization('lnsMetric');
  await PageObjects.lens.assertMetric('Maximum of bytes', '19,986');
@@ -114,6 +114,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
  await listingTable.searchForItemWithName('lnsXYvis');
  await PageObjects.lens.clickVisualizeListItemTitle('lnsXYvis');
  await PageObjects.lens.goToTimeRange();
+ expect(await PageObjects.lens.hasChartSwitchWarning('donut')).to.eql(true);
  await PageObjects.lens.switchToVisualization('donut');
 
  expect(await PageObjects.lens.getTitle()).to.eql('lnsXYvis');
@@ -124,6 +125,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
  'Average of bytes'
  );
 
+ expect(await PageObjects.lens.hasChartSwitchWarning('bar')).to.eql(false);
  await PageObjects.lens.switchToVisualization('bar');
  expect(await PageObjects.lens.getTitle()).to.eql('lnsXYvis');
  expect(await PageObjects.lens.getDimensionTriggerText('lnsXY_xDimensionPanel')).to.eql(
@@ -187,11 +189,12 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
  field: 'bytes',
  });
 
+ expect(await PageObjects.lens.hasChartSwitchWarning('lnsDatatable')).to.eql(false);
  await PageObjects.lens.switchToVisualization('lnsDatatable');
 
- expect(await PageObjects.lens.getDatatableThText()).to.eql('@timestamp per 3 hours');
+ expect(await PageObjects.lens.getDatatableHeaderText()).to.eql('@timestamp per 3 hours');
  expect(await PageObjects.lens.getDatatableCellText(0, 0)).to.eql('2015-09-20 00:00');
- expect(await PageObjects.lens.getDatatableThText(1)).to.eql('Average of bytes');
+ expect(await PageObjects.lens.getDatatableHeaderText(1)).to.eql('Average of bytes');
  expect(await PageObjects.lens.getDatatableCellText(0, 1)).to.eql('6,011.351');
  });
  });

diff --git a/x-pack/test/functional/page_objects/lens_page.ts b/x-pack/test/functional/page_objects/lens_page.ts
@@ -176,9 +176,8 @@ export function LensPageProvider({ getService, getPageObjects }: FtrProviderCont
  */
  async hasChartSwitchWarning(subVisualizationId: string) {
  await this.openChartSwitchPopover();
-
  const element = await testSubjects.find(`lnsChartSwitchPopover_${subVisualizationId}`);
- return await testSubjects.descendantExists('euiKeyPadMenuItem__betaBadgeWrapper', element);
+ return await find.descendantExistsByCssSelector('.euiKeyPadMenuItem__betaBadgeWrapper', element);
  },
 
  /**