code review

src/plugins/data/public/search/errors/painless_error.tsx

@@ -33,7 +33,7 @@ export class PainlessError extends KbnError {
 
  super(
  i18n.translate('data.painlessError.painlessScriptedFieldErrorMessage', {
- defaultMessage: "Error with Painless scripted field '{script}'.",
+ defaultMessage: "Error executing Painless script: '{script}'.",
  values: { script: rootCause?.script },
  })
  );

src/plugins/data/public/search/search_interceptor.test.ts

@@ -91,7 +91,7 @@ describe('SearchInterceptor', () => {
  }
  });
 
- test('Search error should be throttled', async (done) => {
+ test('Search error should be debounced', async (done) => {
  const mockResponse: any = {
  result: 500,
  body: {

src/plugins/data/public/search/search_interceptor.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { get, trimEnd, throttle } from 'lodash';
+import { get, trimEnd, debounce } from 'lodash';
 import { BehaviorSubject, throwError, timer, defer, from, Observable, NEVER } from 'rxjs';
 import { catchError, finalize } from 'rxjs/operators';
 import { CoreStart, CoreSetup, ToastsSetup } from 'kibana/public';
@@ -173,12 +173,16 @@ export class SearchInterceptor {
  * error notification per session.
  * @internal
  */
- private showTimeoutError = throttle((e: SearchTimeoutError) => {
- this.deps.toasts.addDanger({
- title: 'Timed out',
- text: toMountPoint(e.getErrorMessage(this.application)),
- });
- }, 30000);
+ private showTimeoutError = debounce(
+ (e: SearchTimeoutError) => {
+ this.deps.toasts.addDanger({
+ title: 'Timed out',
+ text: toMountPoint(e.getErrorMessage(this.application)),
+ });
+ },
+ 30000,
+ { leading: true, trailing: false }
+ );
 
  /**
  * Searches using the given `search` method. Overrides the `AbortSignal` with one that will abort