Blocks save event filter with a white space name (#101599)

elastic · Jun 9, 2021 · f798bb0 · f798bb0
1 parent f9ca6ff
commit f798bb0
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/...curity_solution/public/management/pages/event_filters/view/components/form/index.test.tsx b/...curity_solution/public/management/pages/event_filters/view/components/form/index.test.tsx
@@ -111,6 +111,23 @@ describe('Event filter form', () => {
  expect(store.getState()!.management!.eventFilters!.form!.hasNameError).toBeFalsy();
  });
 
+ it('should change name with a white space still shows an error', async () => {
+ component = renderComponentWithdata();
+
+ const nameInput = component.getByPlaceholderText(NAME_PLACEHOLDER);
+
+ act(() => {
+ fireEvent.change(nameInput, {
+ target: {
+ value: ' ',
+ },
+ });
+ });
+
+ expect(store.getState()!.management!.eventFilters!.form!.entry!.name).toBe('');
+ expect(store.getState()!.management!.eventFilters!.form!.hasNameError).toBeTruthy();
+ });
+
  it('should change comments', async () => {
  component = renderComponentWithdata();
 

diff --git a/...ns/security_solution/public/management/pages/event_filters/view/components/form/index.tsx b/...ns/security_solution/public/management/pages/event_filters/view/components/form/index.tsx
@@ -91,11 +91,12 @@ export const EventFiltersForm: React.FC<EventFiltersFormProps> = memo(
  const handleOnChangeName = useCallback(
  (e: React.ChangeEvent<HTMLInputElement>) => {
  if (!exception) return;
+ const name = e.target.value.toString().trim();
  dispatch({
  type: 'eventFiltersChangeForm',
  payload: {
- entry: { ...exception, name: e.target.value.toString() },
- hasNameError: !e.target.value,
+ entry: { ...exception, name },
+ hasNameError: !name,
  },
  });
  },