[APM] Show JVM tab for otel java agent

[simitt]

Related: elastic/apm-server#4986 (comment)

When using a java opentelemetry agent to ingest data, the JVM tab should appear in the APM UI. Currently the ui only shows JVM tab when agent.name is java.

[elasticmachine]

Pinging @elastic/apm-ui (Team:apm)

[sorenlouv]

JVM tab is conditionally displayed here:

kibana/x-pack/plugins/apm/public/components/app/service_details/service_detail_tabs.tsx

Lines 170 to 174 in 83e5b6c

	if (isJavaAgentName(agentName)) {
	tabs.push(nodesListTab);
	} else if (agentName && !isRumAgentName(agentName)) {
	tabs.push(metricsTab);
	}

It looks like we can simply update isJavaAgentName here:

kibana/x-pack/plugins/apm/common/agent_name.ts

Lines 50 to 55 in 83e5b6c

	export function isJavaAgentName(
	agentName: string | undefined
	): agentName is 'java' {
	return agentName === 'java';
	}

To this:

export function isJavaAgentName(
  agentName: string | undefined
): agentName is 'java' {
  return agentName === 'java' || agentName === 'opentelemetry/java';
}

[sorenlouv]

@simitt The title of the issue is currently "Show JVM metrics tab independent of agent.name". My suggestion is to still use the agent.name to decide whether to show the JVM tab or not, but include the otel agent name opentelemetry/java when doing so. Sounds ok or do you have better alternatives?

[simitt]

@sqren sounds good.

[hansh0801]

@sqren when this issue is going to fix?

[sorenlouv]

@hansh0801 Currently aiming for 7.14 but can't give any guarantees. If trivial we will also backport the fix as far back as possible.

You can subscribe to this issue to stay updated with the progress.

[cyrille-leclerc]

Thanks @sqren . CC @michaelhyatt & @mikktoki

[hansh0801]

thanks @sqren !

[michaelhyatt]

I am using AWS Distro for OTel with Java lamdas and pointing it at our APM server's OTel intake. In addition to 1 transaction and 1 span I am getting about 30 metrics documents (as per the attached file) that contain various JVM and GC metrics. Can be a great addition to populate the APM UI with.
lambda+metrics.json.txt