Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Observability] Add new loading state to the shared Observability page template for a nice full page loader #101356

Open
formgeist opened this issue Jun 4, 2021 · 3 comments
Open

[Observability] Add new loading state to the shared Observability page template for a nice full page loader #101356

formgeist opened this issue Jun 4, 2021 · 3 comments
Assignees
@afgomez
Labels
enhancement New value added to drive a business result Project:ObservabilitySolutionNavigation Team:Observability Team label for Observability Team (for things that are handled across all of observability) Unified Observability Work to make the observability apps more consistent and eventually more unified as a user experience

Comments

@formgeist
Copy link
Contributor

formgeist commented Jun 4, 2021 •
edited
Loading

Summary

Our friends in EUI have added a new full page loading state to the EuiEmptyPrompt which we can use for displaying a nice full page loader within our template for any app's initial loading state.

image

Previously, we've been displaying different loading states and messages for each app, but it'd be great to make this consistent.

Screenshot 2021-05-27 at 09 00 57

Screenshot 2021-05-27 at 16 01 24
@formgeist formgeist added enhancement New value added to drive a business result Team:Observability Team label for Observability Team (for things that are handled across all of observability) Project:ObservabilitySolutionNavigation blocked labels Jun 4, 2021
@formgeist formgeist removed the blocked label Jun 24, 2021
@formgeist
Copy link
Contributor Author

formgeist commented Jun 24, 2021 •
edited
Loading

The latest EUI updates have merged to Kibana so the new full page loader should now be available for us to make use of in Observability 🙌

@formgeist formgeist added the Unified Observability Work to make the observability apps more consistent and eventually more unified as a user experience label Nov 5, 2021
@afgomez afgomez self-assigned this Jan 5, 2022
@afgomez
Copy link
Contributor

afgomez commented Mar 29, 2022

Is this issue still relevant? Has this been fixed when unifying the ObservabilityPageTemplate?

@formgeist
Copy link
Contributor Author

@afgomez AFAICT we're not using the new loader, at least not for Observability app pages. The other apps (such as UX, Uptime, APM) are all using individual loaders on the first page of the app. We can sort out the Observability pages first and then open subsequent issues for the individual app owners to update their loading states to use the same loader.

CleanShot.2022-03-29.at.13.43.31.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afgomez afgomez

Labels
enhancement New value added to drive a business result Project:ObservabilitySolutionNavigation Team:Observability Team label for Observability Team (for things that are handled across all of observability) Unified Observability Work to make the observability apps more consistent and eventually more unified as a user experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@afgomez @formgeist