Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Logs UI] Replace references to IFieldType #107885

Closed
weltenwort opened this issue Aug 9, 2021 · 2 comments · Fixed by #121108
Closed

[Logs UI] Replace references to IFieldType #107885

weltenwort opened this issue Aug 9, 2021 · 2 comments · Fixed by #121108
Assignees
@Kerry350
Labels
chore Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.0.0

Comments

@weltenwort
Copy link
Member

weltenwort commented Aug 9, 2021 •
edited by zube bot
Loading

📝 Summary

The IFieldType interface is going to be removed because it's too ambiguous. We should replace its usage with either IndexPatternField or IndexPatternFieldBase.

part of #107235

✔️ Acceptance criteria

  • No references to IFieldType exist in the Logs UI codebase.
  • The impacted code remains fully typed using appropriate replacements.
@weltenwort weltenwort added Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.16.0 labels Aug 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@weltenwort weltenwort mentioned this issue Aug 9, 2021
Closed
3 tasks
@Kerry350 Kerry350 self-assigned this Dec 8, 2021
@Kerry350
Copy link
Contributor

Kerry350 commented Dec 8, 2021

Picking this up as it follows on from #120762 nicely and means those chores are out of the way.

@Kerry350 Kerry350 mentioned this issue Dec 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kerry350 Kerry350

Labels
chore Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Infra UI] Replace IFieldType references Kerry350/kibana
4 participants
@jasonrhodes @Kerry350 @weltenwort @elasticmachine