Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet]: Error page on clicking upgrade button for "Windows" integration with v0.8.1. #110202

Closed
amolnater-qasource opened this issue Aug 26, 2021 · 13 comments · Fixed by #110698
Closed
Assignees
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@amolnater-qasource
Copy link

Kibana version: 7.15.0 BC-2 Kibana Cloud environment

Host OS and Browser version: All, All

Build details:

Build: 43742
Commit: 113d5f2a745ab9be7d567d13ff906dfd0f5b7a9a

Preconditions:

  1. 7.15.0 BC-2 Kibana Cloud environment should be available.
  2. Lower version Windows integration should be available, say 0.8.1.

Steps to reproduce:

  1. Login to Kibana environment.
  2. Add Lower version Windows integration to Default Policy.
  3. Observe v0.8.1 version Windows added to Default Policy.
  4. Upgrade Windows integration from Settings, i.e, v1.0.0.
  5. After successful upgrade navigate to Default Policy and click Upgrade button in front of Windows integration.
  6. Observe Error page on clicking Upgrade button.

Expected Result:
On clicking Upgrade button user should be navigated to Upgrade Windows Integration page.

Screen Recording:

New.Policy.-.Agent.policies.-.Fleet.-.Elastic.-.Google.Chrome.2021-08-26.16-09-56.mp4

Note:
This issue is also observed if we create a policy with Windows integration at 7.13.4 Kibana and then Upgrade 7.13.4 Kibana to 7.15.0 Kibana. On clicking Upgrade button user is redirected to Error page.

@amolnater-qasource amolnater-qasource added bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 26, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@amolnater-qasource
Copy link
Author

@manishgupta-qasource Please review.

@manishgupta-qasource
Copy link

Reviewed & assigned to @kpollich

CC: @EricDavisX

@amolnater-qasource
Copy link
Author

Hi @kpollich
We have found that this issue is not reproducible when Windows version 0.1.3 is upgraded to 1.0.0.

Further we have observed similar error page on upgrading Linux version v0.3.1 to latest 0.4.1. However Linux integration successfully upgrades from version 0.3.8 to 0.4.1.

Error page for Linux integration version 0.3.1:
10

Build details:

Build: 43742
Commit: 113d5f2a745ab9be7d567d13ff906dfd0f5b7a9a

Please let us know if anything else is required from our end.
Thanks

@EricDavisX
Copy link
Contributor

can we re-test this on the next passing 7.15 snapshot build please? I expect some fixes may not have made it to BC2 - but are *I think already fixed

@amolnater-qasource
Copy link
Author

Hi @EricDavisX
As per feedback we have revalidated these error page issues for both linux(v0.3.1) and windows(v0.8.1) integration upgrade on latest 7.15.0 Snapshot and found it still reproducible.

Build details:
Build: 43832
Commit: b7ad04c

Please let us know if anything else is required from our end.
Thanks

kpollich added a commit to kpollich/kibana that referenced this issue Aug 31, 2021
Ensure package policy merge logics accounts for cases in which an
input/stream which previously had no variables declared but has
variables in a later package version.

Fixes elastic#110202
kpollich added a commit that referenced this issue Aug 31, 2021
* Fix bug when upgrading Windows package policies

Ensure package policy merge logics accounts for cases in which an
input/stream which previously had no variables declared but has
variables in a later package version.

Fixes #110202

* Refactor original var set into deepMergeVars
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 31, 2021
* Fix bug when upgrading Windows package policies

Ensure package policy merge logics accounts for cases in which an
input/stream which previously had no variables declared but has
variables in a later package version.

Fixes elastic#110202

* Refactor original var set into deepMergeVars
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Aug 31, 2021
* Fix bug when upgrading Windows package policies

Ensure package policy merge logics accounts for cases in which an
input/stream which previously had no variables declared but has
variables in a later package version.

Fixes elastic#110202

* Refactor original var set into deepMergeVars
kibanamachine added a commit that referenced this issue Sep 1, 2021
…10725)

* Fix bug when upgrading Windows package policies

Ensure package policy merge logics accounts for cases in which an
input/stream which previously had no variables declared but has
variables in a later package version.

Fixes #110202

* Refactor original var set into deepMergeVars

Co-authored-by: Kyle Pollich <[email protected]>
kibanamachine added a commit that referenced this issue Sep 1, 2021
…10724)

* Fix bug when upgrading Windows package policies

Ensure package policy merge logics accounts for cases in which an
input/stream which previously had no variables declared but has
variables in a later package version.

Fixes #110202

* Refactor original var set into deepMergeVars

Co-authored-by: Kyle Pollich <[email protected]>
@ghost
Copy link

ghost commented Feb 1, 2022

Hi @kpollich
We have observed this issue reproducible on the latest 7.17.0-BC5 build. Please find below the exact testing details:

  • Error page on clicking upgrade button for "Windows" integration with v0.8.1.

Screenshot:
Screenshot (50)

Build Details:
VERSION: 7.17.0-BC5
BUILD: 46534
COMMIT: 60a9838
ARTIFACT: https://staging.elastic.co/7.17.0-c7ee4c2a/summary-7.17.0.html#artifacts

Thanks!

@ghost ghost reopened this Feb 1, 2022
@amolnater-qasource
Copy link
Author

Further this issue is inconsistently reproducible on 8.0 rc-2 Kibana self-managed environment.

Build details:
BUILD: 49192
COMMIT: 57ca5e1

Screenshot:
10

Thanks!

@kpollich
Copy link
Member

kpollich commented Feb 1, 2022

I'm unable to reproduce this on the main or 8.0 branches in my local environment.

Screen.Recording.2022-02-01.at.3.18.34.PM.mov

Perhaps this is fixed in a later build?

@ghost
Copy link

ghost commented Feb 2, 2022

Hi @kpollich
We have revalidated this issue on the 7.17.0 release build and found that the issue is fixed now. Please find below the testing details:

Screen-Recording:

Windows.-.Integrations.-.Elastic.-.Google.Chrome.2022-02-02.10-30-10.mp4

Build Details:
VERSION: 7.17.0
BUILD: 46534
COMMIT: 60a9838

Thanks!

@amolnater-qasource
Copy link
Author

Hi @kpollich
We have revalidated this issue on 8.0 rc2 BC-4 Kibana cloud build and found this issue not reproducible.

Build details:
BUILD: 49192
COMMIT: 57ca5e1

Screenshot:
2

As shared by @samratbhadra-qasource it is also not reproducible on released 7.17 Kibana, hence we are closing this issue.
Further we will keep track of this issue, if found it reproducible in future builds.

Thanks

@ghost
Copy link

ghost commented Feb 23, 2022

Hi @kpollich
While performing testing on 8.0.1-BC2 build, we have observed that the same issue is still reproducible. Please find below the testing details:

Screen-Recording:

Windows.-.Integrations.-.Elastic.-.Google.Chrome.2022-02-23.13-13-55.mp4

Build Details:
VERSION: 8.0.1-BC2
BUILD: 49348
COMMIT: 28c513e
ARTIFACT: https://staging.elastic.co/8.0.1-e8a5e55a/summary-8.0.1.html

Hence, reopening this issue.

Thanks!

@ghost ghost reopened this Feb 23, 2022
@kpollich
Copy link
Member

Original issue reported was for upgrade of Windows integration v0.8.1 -> 1.0.0. The original issue reported is still working correctly on staging 8.0.1. See below:

image

image


The issue with upgrading from 0.1.3 -> 1.5.0 reported in #110202 (comment) is fixed in 8.1.0. It was fixed in #121628 here:

const errorCount = inputValidationResults && countValidationErrors(inputValidationResults);

image

Since 8.0.1 releases tomorrow on 2022-02-24, and there is no 8.0.2 release scheduled, I'm closing this as the issue is fixed w/ an upgrade to 8.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants