Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core.elasticsearch] Add deprecation warning when scripts are disabled #110566

Closed
lukeelmers opened this issue Aug 31, 2021 · 2 comments · Fixed by #111865
Closed

[core.elasticsearch] Add deprecation warning when scripts are disabled #110566

lukeelmers opened this issue Aug 31, 2021 · 2 comments · Fixed by #111865
Assignees
@pgayvallet
Labels
Feature:elasticsearch Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Aug 31, 2021 •
edited by pgayvallet
Loading

In preparation for #96106, we should:

  • Add a check for if a user has disabled inline scripts in ES (script.allowed_types: none or script.allowed_types: stored )
  • Log an Upgrade Assistant deprecation warning in 7.x
  • Document that using Kibana without scripts enabled in ES is not supported

Then in 8.0 we can go ahead and make the breaking change so that Kibana will fail if scripts are not enabled. (That task will continue to be tracked by #96106)
@lukeelmers lukeelmers added Feature:elasticsearch Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Aug 31, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@lukeelmers lukeelmers mentioned this issue Aug 31, 2021
Closed
@pgayvallet
Copy link
Contributor

Should we use this issue or #96106 to discuss the technicals? (I opened the discussion in #96106 (comment))

@pgayvallet pgayvallet self-assigned this Sep 10, 2021
@pgayvallet pgayvallet mentioned this issue Sep 10, 2021
Merged
2 tasks
@pgayvallet pgayvallet mentioned this issue Sep 24, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgayvallet pgayvallet

Labels
Feature:elasticsearch Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add deprecation warning when inline scripting is disabled pgayvallet/kibana
3 participants
@pgayvallet @lukeelmers @elasticmachine