Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saved objects management: Add warning for UI edit -> read-only UI change #112864

Closed
TinaHeiligers opened this issue Sep 22, 2021 · 4 comments
Closed
Labels
enhancement New value added to drive a business result Feature:Saved Objects Management impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc won't fix

Comments

@TinaHeiligers
Copy link
Contributor

TinaHeiligers commented Sep 22, 2021

In #112034, we changed the edit page to read-only mode. In 7.16, we should warn users about the upcoming change.

Scope:

  • Add a warning that the edit UI will change to a read-only view.
  • Include the link to the saved objects API docs in the warning.
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 22, 2021
@TinaHeiligers TinaHeiligers added enhancement New value added to drive a business result Feature:Saved Objects Management impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed needs-team Issues missing a team label labels Sep 22, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@lukeelmers
Copy link
Member

Oops, just found this issue :) copying my comment from #112034 (comment)

TBH I am not sure if it's worth adding a warning. We agreed in the original issue #59588 (comment) that we didn't want to go out of our way to show users workarounds for manually changing their SOs due to the consequences of messing this up. We could add a general "this is going away" warning, but it probably would just annoy people if we aren't giving them a workaround.

Just my two cents though, I don't have particularly strong feelings on this & would support adding a warning if others felt it was important (we'd just need to wordsmith it carefully)

@TinaHeiligers
Copy link
Contributor Author

TinaHeiligers commented Sep 22, 2021

just found this issue

Ya, I'd only just created it 😉

We could add a general "this is going away" warning, but it probably would just annoy people if we aren't giving them a workaround

Agreed, I don't think it's worth pointing this out, especially because we discourage folks from using it!

I think it's fair to take a 'wait and see' approach. Folks should be using the API's anyway. I've added a 'won't fix' label for now. We can close this issue if that's better.

@afharo
Copy link
Member

afharo commented Dec 1, 2021

Should we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Saved Objects Management impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc won't fix
Projects
None yet
Development

No branches or pull requests

4 participants