Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Reporting] Add isDeprecated: true for v1 PDF and PNG export types. #121365

Closed
tsullivan opened this issue Dec 15, 2021 · 1 comment · Fixed by #123235
Closed

[Reporting] Add isDeprecated: true for v1 PDF and PNG export types. #121365

tsullivan opened this issue Dec 15, 2021 · 1 comment · Fixed by #123235
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@tsullivan
Copy link
Member

Kibana version: 8.1

PNG and PDF export types were reimplemented in #101048. The original implementation needs to be deprecated while support is continued for backwards compatibility.

Requirements:

  1. Rename JobParamsPDF to JobParamsPDFDeprecated
  2. Rename JobParamsPNG to JobParamsPNGDeprecated
  3. Add isDeprecated: true in the create job functions of the two export types
@tsullivan tsullivan added the bug Fixes for quality problems that affect the customer experience label Dec 15, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 16, 2021
@tsullivan tsullivan mentioned this issue Dec 16, 2021
Merged
2 tasks
@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Dec 16, 2021
@dokmic dokmic mentioned this issue Jan 18, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Reporting] Add deprecation flag for v1 PDF and PNG export types dokmic/kibana
2 participants
@tsullivan @elasticmachine