Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove IFieldType from stack monitoring #124168

Closed
Tracked by #107235
smith opened this issue Jan 31, 2022 · 1 comment · Fixed by #124288
Closed
Tracked by #107235

Remove IFieldType from stack monitoring #124168

smith opened this issue Jan 31, 2022 · 1 comment · Fixed by #124288
Assignees
@weltenwort
Labels
Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@smith
Copy link
Contributor

smith commented Jan 31, 2022 •
edited by weltenwort
Loading

📝 Summary

The IFieldType interface is going to be removed because it's too ambiguous. We should replace its usage with either DataViewField or DataViewFieldBase.

part of #107235

✔️ Acceptance criteria

  • No references to IFieldType exist in the stack monitoring codebase.
  • The impacted code remains fully typed using appropriate replacements.
@smith smith mentioned this issue Jan 31, 2022
Closed
3 tasks
@smith smith changed the title x-pack/plugins/monitoring Remove IFieldType from stack monitoring Jan 31, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Jan 31, 2022
@smith smith added Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Jan 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-monitoring-ui (Team:Infra Monitoring UI)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@weltenwort weltenwort self-assigned this Feb 1, 2022
@weltenwort weltenwort mentioned this issue Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weltenwort weltenwort

Labels
Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Stack Monitoring] Replace deprecated esKuery and IFieldType usages weltenwort/kibana
3 participants
@smith @weltenwort @elasticmachine