Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Views] Support of AbortSignal for getFieldsForWildcard #125212

Closed
Tracked by #166175
alexwizp opened this issue Feb 10, 2022 · 4 comments
Closed
Tracked by #166175

[Data Views] Support of AbortSignal for getFieldsForWildcard #125212

alexwizp opened this issue Feb 10, 2022 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0 Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)

Comments

@alexwizp
Copy link
Contributor

Some plugins like TSVB use getFieldsForWildcard method to get fields for es indexes.
I see that inside this method there are calls to es cluster like:

  return await callCluster.fieldCaps({
       index: indices,
       fields: '*'
       ignore_unavailable: true
       index_filter: filter,
       ...fieldCapsOptions,
     });

Since the query behind these fields can take quite a long time when using wildcards indexes, I think we should be able to cancel it

Can we add support for passing AbortSignal?

@alexwizp alexwizp added enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0 labels Feb 10, 2022
@botelastic botelastic bot added the needs-team Issues missing a team label label Feb 10, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Feb 10, 2022
@mattkime
Copy link
Contributor

Since the query behind these fields can take quite a long time when using wildcards indexes

This should rarely be the case as data view loading is dependent upon it. That said, I think it makes sense to be able to cancel queries. Implementation looks straight forward but it would be good to have an initial consumer to verify this works as intended. Could you implement it with guidance and / or review from @elastic/kibana-app-services ?

@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:small Small Level of Effort labels Feb 17, 2022
@exalate-issue-sync exalate-issue-sync bot removed the loe:small Small Level of Effort label Mar 16, 2022
@exalate-issue-sync exalate-issue-sync bot added the loe:small Small Level of Effort label Apr 5, 2022
@kertal kertal added bug Fixes for quality problems that affect the customer experience and removed bug Fixes for quality problems that affect the customer experience labels Nov 18, 2022
@petrklapka petrklapka added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) and removed Team:AppServicesSv labels Nov 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mattkime mattkime added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Dec 18, 2022
@kertal kertal added the Icebox label Sep 24, 2024
@kertal
Copy link
Member

kertal commented Sep 24, 2024

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Data Views Data Views code and UI - index patterns before 8.0 Icebox impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)
Projects
None yet
Development

No branches or pull requests

5 participants