Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor error handling inside embeddable to cover all the edge cases #144224

Open
dokmic opened this issue Oct 31, 2022 · 3 comments
Open

Refactor error handling inside embeddable to cover all the edge cases #144224

dokmic opened this issue Oct 31, 2022 · 3 comments
Labels
Feature:Vega Vega visualizations impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@dokmic
Copy link
Contributor

dokmic commented Oct 31, 2022 •
edited
Loading

Not sure if there are plans to add this error UI to TSVB/Vega visualizations as well? The panel on the left is Aggregation based, whereas the panel on the right is TSVB.
image
And is what it looks like for a Vega visualization:
image
However, from the user's perspective. all three of these panels are both considered "Visualize" panels so it's a bit confusing that there are three different ways of displaying the error.

Originally posted by @Heenawter in #143367 (review)
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 31, 2022
@dokmic dokmic added Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens and removed needs-team Issues missing a team label labels Oct 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors @elastic/kibana-vis-editors-external (Team:VisEditors)

@dokmic dokmic mentioned this issue Oct 31, 2022
Merged
5 tasks
@stratoula stratoula added the [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation label Oct 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@stratoula stratoula mentioned this issue Oct 31, 2022
Closed
@petrklapka petrklapka added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Nov 3, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@dokmic dokmic added Feature:TSVB TSVB (Time Series Visual Builder) Feature:Vega Vega visualizations and removed Feature:Lens Feature:Maps labels Nov 4, 2022
@dokmic dokmic removed the Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas label Nov 4, 2022
@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jan 9, 2023
@stratoula stratoula removed Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:TSVB TSVB (Time Series Visual Builder) labels Jan 26, 2024
@stratoula stratoula mentioned this issue Jan 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Vega Vega visualizations impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@jb1b84 @dokmic @elasticmachine @stratoula @petrklapka