Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Create a filter with field:value when last value metric is used on a datatable #152883

Closed
stratoula opened this issue Mar 8, 2023 · 3 comments · Fixed by #160509
Closed

[Lens] Create a filter with field:value when last value metric is used on a datatable #152883

stratoula opened this issue Mar 8, 2023 · 3 comments · Fixed by #160509
Assignees
@mbondyra
Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@stratoula
Copy link
Contributor

stratoula commented Mar 8, 2023 •
edited
Loading

Describe the feature:
Atm, you can create a filter when you click on a metric on a Lens datatable. It usually creates a field: exists filter. For the last value we can enhance and create a field: value instead of field: *

For example here it could create a Carrier: Jetbeats if I click the metric on the first row.

image
@stratoula stratoula added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Mar 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@timductive timductive added loe:medium Medium Level of Effort impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Mar 9, 2023
@stratoula
Copy link
Contributor Author

Let's also create a list with the filters that are created now by aggregation (I think they are mostly creating field: exists filter) and see if we can make them smarter.

@Jonas-268
Copy link

+1

@stratoula stratoula mentioned this issue May 26, 2023
Closed
@mbondyra mbondyra self-assigned this Jun 15, 2023
@mbondyra mbondyra mentioned this issue Jun 26, 2023
Merged
mbondyra added a commit that referenced this issue Jun 29, 2023
@mbondyra
[Lens] Create a filter with field:value when last value metric is use…
d9b3a53 
…d on a datatable (#160509)

Fixes #152883

The task says this is the behavior that we want for datatable, but with
the way data plugin interacts with Lens, it's actually impossible to
modify only for datatable. In my opinion that's an improvement though,
we probably want the same behavior for all supported visualization (so
also metric).


### Scenarios to test:
<img width="316" alt="Screenshot 2023-06-27 at 09 10 35"
src="https:/elastic/kibana/assets/4283304/55b42b45-2154-4a32-b9e4-01f6fbdc4493">

1,2,3 returns the `price:${value}` filter
4. returns `price:exists` filter
5. returns `category.keyword:${value}` coming from filter by
6. `OR` filter for array values
<img width="419" alt="Screenshot 2023-06-28 at 16 31 43"
src="https:/elastic/kibana/assets/4283304/d7842617-7be3-4b8a-a39f-206a145f9b81">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mbondyra mbondyra

Labels
enhancement New value added to drive a business result Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
5 participants
@timductive @mbondyra @elasticmachine @stratoula @Jonas-268