Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fleet needs to use data view api to create data views, no saved object api #153368

Open
mattkime opened this issue Mar 21, 2023 · 3 comments
Open

Fleet needs to use data view api to create data views, no saved object api #153368

mattkime opened this issue Mar 21, 2023 · 3 comments
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@mattkime
Copy link
Contributor

mattkime commented Mar 21, 2023 •
edited
Loading

Currently, fleet uses the generic saved object api to create data views - x-pack/plugins/fleet/server/services/epm/kibana/index_pattern/install.ts

It should be using the data view api instead. Writing raw saved objects is considered tech debt as there's no contract to ensure the written SO is actually functional.

Further, the allowNoIndices flag is currently ignored as its become the default behavior for data views.
@mattkime mattkime added Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team labels Mar 21, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Feature:Fleet)

@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@jen-huang
Copy link
Contributor

Dupe of #86121 which is old, so I'll close that one in favor of this one :)

This was referenced Mar 21, 2023
Closed
Closed
@jen-huang jen-huang added technical debt Improvement of the software architecture and operational architecture and removed Feature:Fleet Fleet team's agent central management project labels Mar 21, 2023
@kertal kertal mentioned this issue Jul 5, 2023
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattkime @jen-huang @elasticmachine