Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document side effects for numbers outside safe JavaScript range #160876

Open
fdartayre opened this issue Jun 29, 2023 · 9 comments
Open

Document side effects for numbers outside safe JavaScript range #160876

fdartayre opened this issue Jun 29, 2023 · 9 comments

Comments

@fdartayre
Copy link

Document the effects in Kibana of missing support of 64 bit integer values in JavaScript (#40183).

@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 29, 2023
@wayneseymour wayneseymour added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jun 30, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 30, 2023
@pgayvallet
Copy link
Contributor

I'm not sure who should / could be in charge of documenting this, but I know the Core team wouldn't be able to. We can't know what the behavior is in each individual app and each feature of Kibana. I will unassign my team for re-triaging.

@pgayvallet pgayvallet removed the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Jun 30, 2023
@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 30, 2023
@wayneseymour
Copy link
Member

I'm not sure who should / could be in charge of documenting this, but I know the Core team wouldn't be able to. We can't know what the behavior is in each individual app and each feature of Kibana. I will unassign my team for re-triaging.

ok, thanks Pierre.

@wayneseymour
Copy link
Member

@pgayvallet The screenshot shows how I deduced to tag your team, but I'll try to remember next time.
Should saved objects not be listed here?

Screenshot 2023-06-30 at 10 22 03

@pgayvallet
Copy link
Contributor

SavedObjects are definitely under our team's scope.

Not sure to see the link between SOs and documenting edge cases and side effect of 64bit integer overflow in Kibana though?

@wayneseymour
Copy link
Member

Good argument lol

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 30, 2023
@jrodewig
Copy link
Contributor

jrodewig commented Jun 30, 2023

Hi @wayneseymour @fdartayre

Can either of you provide:

The Platform docs team has very limited resources so it's important that we focus on high priority work first.

I also wonder whether this is an opportunity to improve the in-app experience instead of or in addition to updating docs. Many users who encounter the rounding error may not have seen the related docs — even if we make them highly visible. Some type of in-app warning or notification may provide a better experience.

@jrodewig
Copy link
Contributor

From a docs perspective, it may make more sense to note this in the Elasticsearch docs for the potentially affected field types (long, date_nanos, unsigned_long):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants