Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new inspector #16185

Closed
6 tasks
timroes opened this issue Jan 22, 2018 · 3 comments · Fixed by #16387
Closed
6 tasks

Implement new inspector #16185

timroes opened this issue Jan 22, 2018 · 3 comments · Fixed by #16387
Assignees
Labels
Feature:Inspector Inspector infrastructure and implementations Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement

Comments

@timroes
Copy link
Contributor

timroes commented Jan 22, 2018

This is a meta issue, for implementing the new inspector, that will replace the current spy panel solution.

@timroes timroes added release_note:enhancement Feature:Visualizations Generic visualization features (in case no more specific feature label is available) Feature:Inspector Inspector infrastructure and implementations labels Jan 22, 2018
@timroes timroes self-assigned this Jan 22, 2018
@alexfrancoeur
Copy link

@snide had some ideas around the design here and ways to possibly show a visualization alongside the inspector

@snide
Copy link
Contributor

snide commented Jan 26, 2018

First... I'd move the "spy" caret next to the fullscreen button and give it a tooltip that declares what it does. Dunno if this text is the best, but it's better than the hidden ability it is now.

Dashboard panels

image

On open, I'd takeover the screen, and put the viz on the left, and the data table on the right. If you want to allow drag resize of the split that's fine, but probably a S/M/L for the viz itself is all someone would need. I definitely wouldn't fill height / width with anything other than a map object just because it causes some warped displays, but instead try to keep the size ratio of the viz wherever it lived (assuming that it comes from a dashboard / canvas).

I think you also need to explain what the difference between raw and formatted data is. I didn't know, so I'm assuming someone else wouldn't know either. Tooltip on the button would be fine.

Table is dummy, ignore and use your imagination :)

image

All of this should be buildable with existing EUI components.

@AlonaNadler
Copy link

Just finished a call with a customer, the customer was looking for a summary table for the visualization which they can export, I showed them the spy panel. I think one of the reasons they didnt realize it exists is that we use the same icon to hide/show legend
image
It's not clear that it will show spy pannel/visualization summary table, I suggest considering a different icon to the spy panel,
In addition, currently, it's in the bottom on the viz and really easy to miss, maybe we should consider moving it next to the expand icon
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Inspector Inspector infrastructure and implementations Feature:Visualizations Generic visualization features (in case no more specific feature label is available) release_note:enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants