Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Drilldowns] URL Drilldown does not display validation errors and allows saving with invalid state #163641

Open
nreese opened this issue Aug 10, 2023 · 5 comments
Open

[Drilldowns] URL Drilldown does not display validation errors and allows saving with invalid state #163641

nreese opened this issue Aug 10, 2023 · 5 comments
Assignees
@Dosant
Labels
bug Fixes for quality problems that affect the customer experience Feature:Drilldowns Embeddable panel Drilldowns impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@nreese
Copy link
Contributor

nreese commented Aug 10, 2023 •
edited
Loading

Step to view problem

  • upgrade license
  • create dashboard
  • add visualization, create table vis, drag in some fields, click save and return
  • In dashboard panel context menu, click "create drilldown"
  • Select "go to URL" drilldown
  • Select table row click
  • Set url to "https://google.com?q={{invalidstuffhere}}"
  • click save. Notice how there is no notification provided to user that URL is invalid and invalid state is allowed to be saved. Warnings are logged to console, but not surfaced to user. Interface should display errors and abort saving on URL drill down errors.
Screen Shot 2023-08-10 at 11 33 24 AM
@nreese nreese added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Drilldowns Embeddable panel Drilldowns labels Aug 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations @elastic/kibana-visualizations-external (Team:Visualizations)

@ThomThomson
Copy link
Contributor

The ownership of URL drilldowns is still technically @elastic/kibana-app-services. We need to sort out which team owns URL drilldowns. The @vadimkibana, the @elastic/appex-sharedux team owns ui_actions and ui_actions_enhanced. Do you think it makes sense to own the URL drilldowns as well?

@ThomThomson ThomThomson added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated labels Aug 10, 2023
@stratoula
Copy link
Contributor

From this PR it seems that drilldowns are going to be moved in the shared-ux team https:/elastic/kibana/pull/162574/files so I am changing the labels

@stratoula stratoula added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 11, 2023
@vadimkibana vadimkibana changed the title [drilldown] url drill down does not display validation errors and allows saving with invalid state [Drilldowns] URL Drilldown does not display validation errors and allows saving with invalid state Aug 11, 2023
@vadimkibana
Copy link
Contributor

Maybe we could show broken drilldowns in edit mode on Dashboard.

@nreese nreese mentioned this issue Sep 25, 2024
Closed
@teresaalvarezsoler teresaalvarezsoler mentioned this issue Oct 7, 2024
Closed
@Dosant Dosant self-assigned this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
bug Fixes for quality problems that affect the customer experience Feature:Drilldowns Embeddable panel Drilldowns impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:needs-research This issue requires some research before it can be worked on or estimated Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nreese @Dosant @ThomThomson @elasticmachine @stratoula @vadimkibana