Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data views] fields_for_wildcard / fields REST apis can be somewhat slow, move processing to client #172969

Closed
Tracked by #166175
mattkime opened this issue Dec 8, 2023 · 2 comments
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)

Comments

@mattkime
Copy link
Contributor

mattkime commented Dec 8, 2023

A scalability test of the fields_for_wildcard and new fields REST api calls has shown that the processing of larger field_caps responses can be somewhat slow and introduce a fair amount of server load.

Attempts to make the code more efficient have either failed or are too small to make a meaningful difference. Instead, we could move the field_caps response processing to the client. This has the advantage of allowing the browser to skip the processing of the response if its a 304.

We haven't specifically seen any complaints regarding this but I still thought it was worth documenting.

@mattkime mattkime added loe:small Small Level of Effort Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) labels Dec 8, 2023
@mattkime mattkime self-assigned this Dec 8, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@davismcphee davismcphee added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Jan 4, 2024
@kertal
Copy link
Member

kertal commented Oct 21, 2024

Closing this because it's not planned to be resolved in the foreseeable future. It will be tracked in our Icebox and will be re-opened if our priorities change. Feel free to re-open if you think it should be melted sooner.

@kertal kertal closed this as not planned Won't fix, can't repro, duplicate, stale Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)
Projects
None yet
Development

No branches or pull requests

4 participants