Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't use * in saved object searches #20242

Closed
bhavyarm opened this issue Jun 26, 2018 · 11 comments · Fixed by #82693
Closed

can't use * in saved object searches #20242

bhavyarm opened this issue Jun 26, 2018 · 11 comments · Fixed by #82693
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Saved Objects regression Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@bhavyarm
Copy link
Contributor

Kibana version: master

Browser version: chrome latest

Browser OS version: os x

Original install method (e.g. download page, yum, from source, etc.): from snapshots

Describe the bug: Search isn't working on search bar on the new saved objects page.

search_doesn t_work

@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience blocker :Management labels Jun 26, 2018
@jen-huang
Copy link
Contributor

jen-huang commented Jun 26, 2018

Replicated bug - this only happens when * is present in the query. logstash searches fine. Removing blocker label since * can just be omitted (redundant as all queries are partial match already).

@jen-huang jen-huang removed the blocker label Jun 26, 2018
@jen-huang
Copy link
Contributor

Further investigation - search behavior is inconsistent. Might be a combination of the search bar parsing and saved objects find api.

@jen-huang
Copy link
Contributor

Two fold issue:

  • EuiSearchBar errors out on certain characters, causing logstash-* to never be queried, EUI bug opened Can't use _ or * in EuiSearchBar eui#951
  • Saved objects _find endpoint doesn't retrieve partial matches for all queries. For example, logstash and dashboard returns results, but not stash and board:

screen shot 2018-06-27 at 10 24 01 pm

screen shot 2018-06-27 at 10 24 13 pm

@jen-huang jen-huang self-assigned this Jun 28, 2018
@LeeDr LeeDr added v6.5.0 and removed v6.4.0 labels Jul 25, 2018
@rayafratkina
Copy link
Contributor

@jen-huang @bhavyarm was this issue fixed as part of EUI conversion?

@jen-huang
Copy link
Contributor

@rayafratkina No, this was found after EUI conversion so is still outstanding.

@spalger spalger added v6.5.1 and removed v6.5.0 labels Nov 14, 2018
@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc and removed :Management DO NOT USE labels Nov 27, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@timroes timroes removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 30, 2018
@LeeDr LeeDr removed the v6.5.1 label Jan 31, 2019
@LeeDr
Copy link
Contributor

LeeDr commented Jan 31, 2019

on 6.6.0 searches work on both partial and full terms "ngi" and "nginx" both find saved objects containing nginx.
But any search containing * returns no results. Is that a regression? From when? It's the same in 6.4.2.
Searching on the Discover saved searches, or Visualization landing page, or Dashboard landing page with * also shows no results. So it's all consistent for the last couple of major releases.

In light of that, I think we should update the description to can't use * in saved object searches.

@LeeDr LeeDr changed the title Searching on search bar on saved objects is not working can't use * in saved object searches Jan 31, 2019
@jinmu03
Copy link
Contributor

jinmu03 commented Jan 31, 2019

@epixa @LeeDr should we treat this as a blocker for 6.7?

@epixa
Copy link
Contributor

epixa commented Jan 31, 2019

@jinmu03 This has been in the wild for a little while, so I don't think blocking a new release will help anything.

@jen-huang jen-huang removed their assignment Sep 23, 2019
@pgayvallet
Copy link
Contributor

Similar to #5734 and will be solved at the same time. Please refer to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Feature:Saved Objects regression Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants