Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify BasePath service on client and server #35816

Closed
mshustov opened this issue Apr 30, 2019 · 0 comments · Fixed by #38237
Closed

Unify BasePath service on client and server #35816

mshustov opened this issue Apr 30, 2019 · 0 comments · Fixed by #38237
Assignees
@eliperelman
Labels
Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Apr 30, 2019 •
edited
Loading

New platform on server side hasn't got base path service, although base path value it's configured via http service config.
New platform on client side considers base path as a separate service.
We should unify definition of BasePath service, probably it should be a part of Http service. Also we would like to have similar api for BasePath on server and client. Use https:/elastic/kibana/blob/master/src/core/public/base_path/base_path_service.ts for references

PR for the client part: #36611
@mshustov mshustov added release_note:enhancement Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Apr 30, 2019
@mshustov mshustov mentioned this issue May 5, 2019
Merged
11 tasks
@joshdover joshdover assigned joshdover and eliperelman and unassigned joshdover May 8, 2019
@mshustov mshustov mentioned this issue May 27, 2019
Merged
7 tasks
@mshustov mshustov added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. and removed release_note:enhancement labels Jun 5, 2019
@mshustov mshustov mentioned this issue Jun 6, 2019
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eliperelman eliperelman

Labels
Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify base path in HttpService mshustov/kibana
3 participants
@eliperelman @joshdover @mshustov