-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] [Embeddables] Provide ability to edit actions displayed in context menu and on map #43643
Comments
Pinging @elastic/kibana-gis |
cc @streamich |
Pinging @elastic/kibana-app-arch |
I think this sounds like a good idea. Perhaps |
Similarly so, as shown in #43642, being able to disable the default |
disabledActions
property to embeddable inputs.disabledActions
input—don't render disabled actions.disabledActions
to[CUSTOM_TIME_RANGE_ACTION, CUSTOM_TIME_RANGE_BADGE]
.See full description below.
In integrating maps into the SIEM App with the Embeddables API, we want to customize the map such that the
CustomTimeRangeAction
does not show up in the context menu, and that theCustomTimeRangeBadge
panel does not show in the top left corner of the map (highlighted below).We need to hide these components/actions as the SIEM App manages the global time range, and we want to hide any additional controls to simplify the experience/ui for our users.
Currently it doesn't look as if there's any way to disable these components directly for a given embeddable without removing the action entirely, e.g.
which results in the following desired UI, but will also remove those actions for any embeddable registered with the same api instance....not good. 😬
It looks as if the context menu checks for the action's compatibility with the embeddable before displaying a menu item -- perhaps we can set some sort of action enabled state on the embeddable's
input
that either the action or context menu could use to conditionally display? (Similarly so for the TimerangeBadge /CustomTimeRangeBadge
?)Please let me know if I've missed some part of the API where these UI elements can configured -- thanks!
cc @stacey-gammon @nreese
The text was updated successfully, but these errors were encountered: