Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove temporary x-pack/legacy/plugins/graph eslint overrides #49561

Closed
spalger opened this issue Oct 28, 2019 · 2 comments · Fixed by #50907
Closed

Remove temporary x-pack/legacy/plugins/graph eslint overrides #49561

spalger opened this issue Oct 28, 2019 · 2 comments · Fixed by #50907
Assignees
@flash1293
Labels
chore Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@spalger
Copy link
Contributor

spalger commented Oct 28, 2019 •
edited
Loading

In order to move forward with #49244 we needed to disable some rules in x-pack/legacy/plugins/graph. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['x-pack/legacy/plugins/graph/**/*.{js,ts,tsx}'],
  rules: {
    'react-hooks/exhaustive-deps': 'off',
  },
},
@spalger spalger added the chore label Oct 28, 2019
@spalger spalger mentioned this issue Oct 28, 2019
Open
31 tasks
@timroes timroes added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Nov 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added the Feature:Graph Graph application feature label Nov 18, 2019
@timroes
Copy link
Contributor

timroes commented Nov 18, 2019

cc @flash1293

@flash1293 flash1293 self-assigned this Nov 18, 2019
@flash1293 flash1293 mentioned this issue Nov 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flash1293 flash1293

Labels
chore Feature:Graph Graph application feature Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix linting errors in graph flash1293/kibana
4 participants
@timroes @spalger @flash1293 @elasticmachine