-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NP Licensing service #50931
Labels
blocker
Feature:New Platform
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Comments
mshustov
added
blocker
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Feature:New Platform
labels
Nov 18, 2019
Pinging @elastic/kibana-platform (Team:Platform) |
13 tasks
25 tasks
closed as a duplicate of #18356 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocker
Feature:New Platform
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Actions
xpack_main/hacks/check_xpack_info_change
to the NP serviceonPreResponse
interceptor in Http service to injectsignature
header under the different name. NP licensing plugin improvements #51818refresh
should be blocking operation to make sure that server error wasn't a result of license change https:/elastic/x-pack-kibana/pull/2876/files#diff-0fa2a179c15c5afc59d4e7beb9fadcc9R2-R4 NP licensing plugin improvements #51818/api/xpack/v1/info
. NP Licensing service info endpoint #51188the full context
for me it sounds like a Kibana-wide problem and something that we must be mentioned in the convention docs.
/_xpack
to/_license
endpoint./_license
returns license status only. we need to investigate what is a substitution for a set of features.{license$}
or a getterget() => license$
. The latter can simplify mocking. Unify approach for the all platform API.enterprise
license type for parity with the LP Support 'enterprise' license type #49474The main changes
state
LP: The plugin allows consumers to calculate state on
license change
event and store thisThe signature calculation is based on this state + license content
NP: We decided that license service doesn't keep plugins state #49345 (comment). Plugins have to react on license change and calculate license state on every license change. If another plugin needs that information, it should be exposed via a plugin contract.
This change makes NP & LP licensing service not compatible. We have to keep both until all plugins migrate to the new platform service.
Network request failures
LP: The licensing plugin didn’t emit a license in case of network errors.
NP: Emits the license even if the request failed.
clusterSource
LP: Allows specifying cluster source to perform polling. Monitoring uses this functionality plugin
NP: The plugin always uses
data
client. If we want to support the case for monitoring we can expose already existing functionality by team request.Initial value on the client
LP: Passed on the page via inlined
xpackInitialInfo
NP: Should be fetched
Config
LP:
xpack.xpack_main.xpack_api_polling_frequency_millis
NP:
xpack.licensing.pollingFrequency
License
NP:
mode
field not provided anymoresessionStorage
LP: License and signature were stored under different keys in session storage
NP: License and signature were stored under one key
xpack.licensing
The text was updated successfully, but these errors were encountered: