Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve filter test mocks #52181

Closed
1 task
streamich opened this issue Dec 4, 2019 · 2 comments
Closed
1 task

Improve filter test mocks #52181

streamich opened this issue Dec 4, 2019 · 2 comments
Assignees
@lizozom
Labels
Feature:Filters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. test-unit

Comments

@streamich
Copy link
Contributor

streamich commented Dec 4, 2019 •
edited
Loading

Currently Filters service in data plugin creates unnecessarily big test snapshots that capture entire API of our services. See:

Tests in should not snapshot API of core and other plugins.

  • Remove core and plugin API from Jest snapshots.
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@streamich streamich mentioned this issue Dec 4, 2019
Merged
5 tasks
@mshustov mshustov mentioned this issue Dec 17, 2019
Merged
3 tasks
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 2, 2021
@exalate-issue-sync exalate-issue-sync bot removed the loe:small Small Level of Effort label May 12, 2022
@ppisljar
Copy link
Member

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@ppisljar ppisljar closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lizozom lizozom

Labels
Feature:Filters impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. test-unit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lizozom @streamich @ppisljar @elasticmachine