Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup IFieldType type in data plugin #54894

Closed
timroes opened this issue Jan 15, 2020 · 3 comments
Closed

Cleanup IFieldType type in data plugin #54894

timroes opened this issue Jan 15, 2020 · 3 comments
Labels
chore Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)

Comments

@timroes
Copy link
Contributor

timroes commented Jan 15, 2020

Part of #61760

I think we should do some TypeScript type cleanup on the IFieldType in the data plugin. It's a very central type that is/will be used in a lot of places, and I think it's currently not typed ideal.

As far as I can see the Field class is the only implementation on it, and if we look into that, it seems that the type is overly careful:

The following properties can never be undefined and we can remove the ? from them: aggregatable, searchable, scripted, visualizable. It also seems we now have a type for format.

Also I wonder if we could provide a type for how the JSON inside the saved object looks. Since we're currently only support index patterns on the client side, we have a couple of places we load the index pattern saved object on the server manually, and parse the attributes from it. It would be good if we would have a type from the data plugin showing how the format of this is, until we're having server side index pattern support.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers added chore Feature:Data Views Data Views code and UI - index patterns before 8.0 labels Jan 21, 2020
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@petrklapka petrklapka added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews) and removed Team:AppServicesSv labels Nov 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@kertal
Copy link
Member

kertal commented Jun 7, 2023

Closing in favor of #107235

@kertal kertal closed this as completed Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Data, DataViews)
Projects
None yet
Development

No branches or pull requests

5 participants