Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy deprecations adapters are wrongly applied from the root level #54934

Closed
pgayvallet opened this issue Jan 15, 2020 · 2 comments
Closed

Legacy deprecations adapters are wrongly applied from the root level #54934

pgayvallet opened this issue Jan 15, 2020 · 2 comments
Assignees
@pgayvallet
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform regression Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

When migrating config deprecation to the new platform, I wrongly understood that legacy plugin deprecations were applied to the root configuration.

TIL they are actually applied on their configuration prefix, and cannot impact configuration outside of it.

The adapters we created in src/core/server/legacy/config/legacy_deprecation_adapters.ts needs to be fixed to actually replicate the correct legacy behavior.
@pgayvallet pgayvallet added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jan 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet pgayvallet self-assigned this Jan 15, 2020
@mshustov
Copy link
Contributor

mshustov commented Sep 6, 2020

legacy deprecations removed in #76536

@mshustov mshustov closed this as completed Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgayvallet pgayvallet

Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform regression Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pgayvallet @mshustov @elasticmachine