Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Persist timerange/pinned filters across reload/apps #61758

Closed
timroes opened this issue Mar 30, 2020 · 4 comments · Fixed by #68075
Closed

[Lens] Persist timerange/pinned filters across reload/apps #61758

timroes opened this issue Mar 30, 2020 · 4 comments · Fixed by #68075
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@timroes
Copy link
Contributor

timroes commented Mar 30, 2020

When users navigate between applications Lens should keep the timerange and pinned filters from other applications. Also a page reload in Lens should not lose the query and non-pinned filters.

@timroes timroes added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens :Lens/basic-expectation labels Mar 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

Pinned filters should also be persisted, right?

@mbondyra
Copy link
Contributor

mbondyra commented May 27, 2020

Test cases for timerange:

  • go to lens, change the time range to X and go to other App [eg Dashboard].
  • go to Dashboard, change the time range to X and go to lens.
  • go to Lens, change the time range, refresh - this one has to be built.

It works the same for pinned filters -> within navigating in the app pinned filters are persisted until user refreshes the page in lens.

@flash1293
Copy link
Contributor

It probably makes sense to use the same state sync helper as discover/visualize/dashboard are using to sync the current state of the filter bar (time range, query and filter pills) with the URL.

This way we get another related behavior for free:

  • Go to Lens, save visualization, copy link and put it in an email, other person clicks the link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants