Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Transforms: add throttling UI support #62740

Closed
hendrikmuhs opened this issue Apr 7, 2020 · 5 comments · Fixed by #65365
Closed

[ML] Transforms: add throttling UI support #62740

hendrikmuhs opened this issue Apr 7, 2020 · 5 comments · Fixed by #65365
Assignees
Labels
enhancement New value added to drive a business result Feature:Transforms ML transforms :ml v7.8.0

Comments

@hendrikmuhs
Copy link
Contributor

hendrikmuhs commented Apr 7, 2020

depends on: elastic/elasticsearch#54862

The backend will add support for optional throttling, this is a numeric setting: requests_per_second.

Discuss: A slider would be nice, however it's unclear what the max is. I could add a recommendation in the _preview API by calculating an average requests per second from existing transforms.

@hendrikmuhs hendrikmuhs added enhancement New value added to drive a business result :ml Feature:Transforms ML transforms labels Apr 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@walterra
Copy link
Contributor

walterra commented May 6, 2020

The feature to edit throttling is now in the UI (#65365).

@hendrikmuhs Would be great if you get a chance to test it, please also have a look if you're happy with the wording in the form. At the moment it's not very obvious to users which values might be good for tuning the throttling.

I could add a recommendation in the _preview API by calculating an average requests per second from existing transforms.

Is that something you got around to do or still plan to do?

@hendrikmuhs
Copy link
Contributor Author

I could add a recommendation in the _preview API by calculating an average requests per second from existing transforms.

Is that something you got around to do or still plan to do?

I still think this is a good idea and we should at least prototype it, for a future version, not 7.8.

@hendrikmuhs
Copy link
Contributor Author

Tested it, looks great.

Note that update allows more:

  • changing source: useful regarding the query, e.g. to filter out noise
  • changing dest: useful when the user realizes that he wants to use ILM and set an alias here

So this is another reason for a json editor component or adding the specific parts, which might get complicated. As a mitigation until that is in place, we could add a sentence on the top, where you already link the docs.

@walterra
Copy link
Contributor

Thanks for the feedback! I included it in the follow-up meta issue about editing transforms here: #67255

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Transforms ML transforms :ml v7.8.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants