Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Integration Configurations should be constrained to be unique names #68275

Closed
EricDavisX opened this issue Jun 4, 2020 · 6 comments
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@EricDavisX
Copy link
Contributor

Kibana version:
Testing with 7.8 BC 5 on June 4 2020 and it is confusing if there are configs of the same name. Ruflin may know more and have feelings on how we fix it, but thats the quick bug. I didn't see it logged, but I saw this for Data Sources and we decided to keep them separate since its a separate API call that needs to do the checking.

Describe the bug:
you can create config 'foo' and then create another config 'foo' and this can lead to problems, better to avoid it, even if it works and is not an architecture requirement currently.

Expected behavior:
a pleasant error message saying perhaps, "The name you entered is in use, please enter a unique name."

Screenshots (if relevant):
Screen Shot 2020-06-04 at 11 43 10 AM

@EricDavisX EricDavisX added Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta1 labels Jun 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ruflin
Copy link
Member

ruflin commented Jun 8, 2020

++ on making the config name unique.

@mostlyjason mostlyjason changed the title [Ingest Manager] Ingest Configurations should be constrained to be unique names [Ingest Manager] Integration Configurations should be constrained to be unique names Jul 23, 2020
@mostlyjason
Copy link
Contributor

@ph We are finding ourselves needing to add extra columns to tables because we can't rely on the integration name being unique. Would be nicer to offer a simpler UX.

@jen-huang
Copy link
Contributor

@jfsiii I think we completed this with recent work? Can you reference the PRs?

@jfsiii
Copy link
Contributor

jfsiii commented Oct 16, 2020

@jen-huang yes, the PRs are #79201 & #80506

@jen-huang
Copy link
Contributor

@mostlyjason Closing as we completed this for 7.10 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

6 participants