Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Show chosen metric color in dimension trigger #68405

Closed
flash1293 opened this issue Jun 5, 2020 · 2 comments · Fixed by #76871
Closed

[Lens] Show chosen metric color in dimension trigger #68405

flash1293 opened this issue Jun 5, 2020 · 2 comments · Fixed by #76871
Assignees
@flash1293
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

flash1293 commented Jun 5, 2020 •
edited
Loading

For features like #53660 and #53661 the visualization has to be able to render a piece of UI as part of the trigger.

To do so, it is necessary to introduce a new API for visualizations. It has to be decided whether this is another render* API or a config object.

If this API is introduced, it should be used by the xy visualization to show the overwrite color of the series if it's set and there is no break down by dimension.

Screen Shot 2020-02-10 at 14 47 59 PM
@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jun 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon wylieconlon changed the title Lens] Architectural requirement: Visualizations can participate in dimension trigger rendering [Lens] Architectural requirement: Visualizations can participate in dimension trigger rendering Jul 1, 2020
@wylieconlon
Copy link
Contributor

Pushing this back because I think we can ship these features in a limited way without the extra widgets in the dimension.

@flash1293 flash1293 changed the title [Lens] Architectural requirement: Visualizations can participate in dimension trigger rendering [Lens] Show chosen metric color in dimension trigger Aug 11, 2020
@flash1293 flash1293 self-assigned this Sep 7, 2020
@flash1293 flash1293 mentioned this issue Sep 7, 2020
Merged
@flash1293 flash1293 added the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 30, 2020
@flash1293 flash1293 removed the loe:needs-research This issue requires some research before it can be worked on or estimated label Oct 12, 2020
@flash1293 flash1293 mentioned this issue Nov 4, 2020
Merged
@dej611 dej611 mentioned this issue Jan 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@flash1293 flash1293

Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Color in dimension trigger flash1293/kibana
3 participants
@wylieconlon @flash1293 @elasticmachine