-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misleading error message when creating a webhook connector with invalid URL #68662
Comments
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
We have two different types of action params you can whitelist - URLs (used in most cases in our actions) and host names (used at least by the email action). The URL whitelisting code seems to be generating this non-intuitive message. Seems like it should be doing a bit more work to validate the URL before doing the whitelist check, if that's what's happening. Eg, I'd expect a URL without a protocol to generate a message indicating the URL didn't provide a protocol, in this case. I'm hoping we can use (one of) Node's built-in URL object(s) to do a validation that would provide a reasonable error message that we can eventually display in the UI. |
Kibana version:
7.7.1
Elasticsearch version:
7.7.1
Server OS version:
macOS Mojave
10.14.6
Browser version:
Google Chrome Version 83.0.4103.61 (Official Build) (64-bit)
Original install method (e.g. download page, yum, from source, etc.):
Downloaded tar.gz from the download page.
Describe the bug:
When creating a Webhook connector in "Alerts and Actions" page, it requires the protocol (
http://
,https://
). Providing the following valueexample.com/do-something
results in an error message that isn't intuitive (xpack.actions.whitelistedHosts defaults to [*]):Steps to reproduce:
Expected behavior:
I think there are some options when using
example.com/do-something
for URL:http://
protocol;Screenshots (if relevant):
The text was updated successfully, but these errors were encountered: