Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Cancel button in editors to go back to the dashboard without saving the changes #70650

Closed
AlonaNadler opened this issue Jul 2, 2020 · 6 comments · Fixed by #77608
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@AlonaNadler
Copy link

If a user gets to the editor from a dashboard and decides not to save the changes, there is no clear way to cancel and go back to the dashboard.
The back button will take them back without adding anything but we should have something Explicit since users will either miss it or won't be clear it doesn't save the changes. A cancel button would be a good addition in this case

@AlonaNadler AlonaNadler added Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jul 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added the enhancement New value added to drive a business result label Jul 6, 2020
@AlonaNadler
Copy link
Author

@ThomThomson @majagrubic playing more with the master. I really we need a cancel/return button. In some cases, I had to click 3-6 times on the back button if I created a panel and wanted to cancel and go back to my dashboard
Jul-29-2020 09-34-57

@ThomThomson
Copy link
Contributor

thanks for looking further into this @AlonaNadler. I agree it's totally needed, due to how the url handles state sometimes in these applications. I added a cancel button to my lens by value PR #70272.

cancelButton

@majagrubic
Copy link
Contributor

I'm working on this now. Is the expectation that the "Cancel" button appears in all visualizations, or just when dealing with by-value visualizations? Ie. do we want to introduce it for the existing flow as well? @AlonaNadler

@AlonaNadler
Copy link
Author

When coming from a dashboard it needs to show the cancel button.
The cancel button needs to show up in all editors (at least in Lens). When users create a new panel or when users open existing panels for editing they should see the cancel button.

@ThomThomson
Copy link
Contributor

@AlonaNadler would it make sense to have the cancel button when coming from the visualize library too? And the cancel button would redirect back to the listing page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants