Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service maps: test 5: user loads service maps without anomaly detection integration when xpack.ml.enabled: false #72914

Closed
cauemarcondes opened this issue Jul 22, 2020 · 10 comments · Fixed by #73638
Closed

[APM] Service maps: test 5: user loads service maps without anomaly detection integration when xpack.ml.enabled: false #72914

cauemarcondes opened this issue Jul 22, 2020 · 10 comments · Fixed by #73638
Assignees
@ogupte
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.9.0

Comments

@cauemarcondes
Copy link
Contributor

Clicking on Anomaly detection to enable ML with the plugin disabled (xpack.ml.enabled: false) breaks APM page.

Screenshot 2020-07-22 at 19.00.38.png
@cauemarcondes cauemarcondes added [zube]: (7.9) Planned for release bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.9.0 labels Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv
Copy link
Member

Thanks for testing this @cauemarcondes ! Was this part of the test plan? If not, please add it. Additionally, can you also add a line to check if there are no available ml nodes? It's something like xpack.ml.node (can't remember exactly)

@cauemarcondes
Copy link
Contributor Author

cauemarcondes commented Jul 23, 2020 •
edited
Loading

Was this part of the test plan?

Yes, it was.

Additionally, can you also add a line to check if there are no available ml nodes? It's something like xpack.ml.node

WIll check what's the exact name and add in the test plan.

@jgowdyelastic
Copy link
Member

jgowdyelastic commented Jul 23, 2020 •
edited
Loading

ML has its own capabilities endpoint and shared function to use to check if it is enabled:
/api/ml/ml_capabilities or mlCapabilities in mlSystemProvider
we have an open issue to add the node count to that response:
#67412

For now you can call /api/ml/ml_node_count to get this count.
if you need it as a shared function for calling server side, I can add it.

@sorenlouv
Copy link
Member

@jgowdyelastic Thanks for chiming in! What I would like is a test case where we intentionally disable the ML node and then see how the ui behaves. I seem to recall there is an kibana.yml config option but can't remember what it's called.

@ogupte ogupte self-assigned this Jul 27, 2020
ogupte added a commit to ogupte/kibana that referenced this issue Jul 29, 2020
@ogupte
Closes elastic#72914 by hiding anomaly detection settings links when …
3b7c04d 
…the ml plugin is disabled.
@ogupte ogupte mentioned this issue Jul 29, 2020
Merged
ogupte added a commit that referenced this issue Jul 30, 2020
@ogupte @elasticmachine
Closes #72914 by hiding anomaly detection settings links when the ml …
5e86d2f 
…plugin is disabled. (#73638)

Co-authored-by: Elastic Machine <[email protected]>
@ogupte ogupte mentioned this issue Jul 30, 2020
Merged
ogupte added a commit to ogupte/kibana that referenced this issue Jul 30, 2020
@ogupte
Closes elastic#72914 by hiding anomaly detection settings links when …
40d348e 
…the ml plugin is disabled. (elastic#73638)

Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/add_environments.tsx
#	x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/index.tsx
@ogupte ogupte mentioned this issue Jul 30, 2020
Merged
ogupte added a commit to ogupte/kibana that referenced this issue Jul 30, 2020
@ogupte
Closes elastic#72914 by hiding anomaly detection settings links when …
a57a3f1 
…the ml plugin is disabled. (elastic#73638)

Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/add_environments.tsx
#	x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/index.tsx
#	x-pack/plugins/apm/public/components/app/Settings/index.tsx
gmmorris added a commit to gmmorris/kibana that referenced this issue Jul 31, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
28b1676 
* master: (54 commits)
  [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941)
  [Discover] Improve  saveSearch functional test handling (elastic#73626)
  [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708)
  [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735)
  [SIEM] Fixes "include building block button" to operate (elastic#73900)
  [Metrics UI] Fix alert management to open without refresh (elastic#73739)
  [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865)
  [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555)
  [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867)
  [Maps] upgrade turf (elastic#73816)
  [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558)
  [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745)
  [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761)
  [Metrics UI] Fix previewing of No Data results (elastic#73753)
  Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638)
  [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833)
  [DOCS] Fixes typo in Alerting actions (elastic#73756)
  [APM] fixes linking errors to ML and Discover (elastic#73758)
  Handle promise rejections when building artifacts (elastic#73831)
  [Security Solution][Detections] Change from sha1 to sha256 (elastic#73741)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this issue Jul 31, 2020
@gmmorris
Merge branch 'master' into task-manager/fix-flaky-test
ce2ee00 
* master: (38 commits)
  [Discover] Context unskip date nanos functional tests (elastic#73781)
  [ML] Migrate to React BrowserRouter and Kibana provided History. (elastic#71941)
  [Discover] Improve  saveSearch functional test handling (elastic#73626)
  [Metrics UI] Fix all threshold alert conditions disappearing due to alert prefill (elastic#73708)
  [Metrics UI] Fix alert previews of ungrouped alerts (elastic#73735)
  [SIEM] Fixes "include building block button" to operate (elastic#73900)
  [Metrics UI] Fix alert management to open without refresh (elastic#73739)
  [Security Solution][Lists] - Tests cleanup and remove unnecessary import (elastic#73865)
  [Ingest Management] main branch uses epr-snapshot. Others production (elastic#73555)
  [Canvas][tech-debt] Fix SVG not shrinking vertically properly (elastic#73867)
  [Maps] upgrade turf (elastic#73816)
  [Security Solution][Telemetry] Concurrent telemetry requests (elastic#73558)
  [Security Solution][Exceptions] - Update how nested entries are displayed in exceptions viewer (elastic#73745)
  [Security Solution][Exceptions] Adds autocomplete workaround for .text fields (elastic#73761)
  [Metrics UI] Fix previewing of No Data results (elastic#73753)
  Closes elastic#72914 by hiding anomaly detection settings links when the ml plugin is disabled. (elastic#73638)
  [Ingest Manager] Fix config selection in enrollment flyout from config list page (elastic#73833)
  [DOCS] Fixes typo in Alerting actions (elastic#73756)
  [APM] fixes linking errors to ML and Discover (elastic#73758)
  Handle promise rejections when building artifacts (elastic#73831)
  ...
ogupte added a commit that referenced this issue Jul 31, 2020
@ogupte
Closes #72914 by hiding anomaly detection settings links when the ml …
1f22d16 
…plugin is disabled. (#73638) (#73890)

Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/add_environments.tsx
#	x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/index.tsx
ogupte added a commit that referenced this issue Jul 31, 2020
@ogupte
Closes #72914 by hiding anomaly detection settings links when the ml …
d834429 
…plugin is disabled. (#73638) (#73892)

Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/add_environments.tsx
#	x-pack/plugins/apm/public/components/app/Settings/anomaly_detection/index.tsx
#	x-pack/plugins/apm/public/components/app/Settings/index.tsx
@sorenlouv
Copy link
Member

@cauemarcondes / @ogupte Did you find a way to disable the ML node via kibana.yml or similar?

@cauemarcondes
Copy link
Contributor Author

@cauemarcondes / @ogupte Did you find a way to disable the ML node via kibana.yml or similar?

Actually no, the discussion ended up here #72914 (comment)

@sorenlouv
Copy link
Member

Okay, since this is a real (ish) problem (I ran into it on Elastic Cloud I think) it would be nice to know how to simulate and see how the ui behaves.

@jgowdyelastic
Copy link
Member

Actually no, the discussion ended up here #72914 (comment)

Apologies, I don't think I saw this.
It's possible to disable ML on the node by adding node.ml: false in the elasticsearch.yml file.

@sorenlouv
Copy link
Member

It's possible to disable ML on the node by adding node.ml: false in the elasticsearch.yml file.

Great! I think that's what I was looking for!

@cauemarcondes : I think you can test this with the apm-integration-testing command

scripts/compose.py start master --elasticsearch-java-opts="node.ml=false"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.9.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Hide anomaly detection APM settings links when ml plugin is disabled ogupte/kibana
5 participants
@sorenlouv @ogupte @elasticmachine @jgowdyelastic @cauemarcondes