-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Lens] Field stats endpoint does not need to use sampler aggregation #74595
Comments
Pinging @elastic/kibana-app (Team:KibanaApp) |
@wylieconlon Are you sure not using sampler is better than using it in cases where it really matters (super large data sets)? From the documentation you linked:
Probably missing a nuance here. |
@flash1293 Because we don't use any of those aggregations when calculating the samples, that part is not relevant. The other example use case is potentially relevant, with caveats:
This part actually might be relevant if the user has added a rank-affecting query to the Lens editor before clicking on the preview. Exact match queries wouldn't have any effect, but a query with Because it's such a narrow subset of queries that affect the results, I would say that the sampler is not useful. |
Ah, I forgot we aren't using aggregations for gathering the stats - makes total sense in that case, thanks. |
We have changed the implementation so this is not valid anymore |
Originally, we thought that the sampler aggregation would behave like a random sampling query, with improved performance across large datasets. This is not what the sampler aggregation actually does, which means that we are doing more work instead of less. This aggregation can be removed entirely.
The text was updated successfully, but these errors were encountered: