Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] The incorrect count is displayed in "Update 101 Elastic prebuilt rules" under Detections rules when upgraded the build from 7.9.2 to 7.10.0. #80470

Closed
ghost opened this issue Oct 14, 2020 · 12 comments
Labels
8.9 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.0

Comments

@ghost
Copy link

ghost commented Oct 14, 2020

Kibana version:
Kibana: 7.10.0 BC1

Elasticsearch version:
Elasticsearch: 7.10.0 BC1

Host OS and Browser version:
Windows, All

Describe the bug
The incorrect count is displayed in "Update 101 Elastic prebuilt rules" under Detections rules when upgraded the build from 7.9.2 to 7.10.0.

Build Details:
Elastic-Stack : 7.10.0 BC1
Artifacts: https://staging.elastic.co/7.10.0-116336aa/summary-7.10.0.html

Preconditions

  1. Cloud environment 7.9.2 should exist.
  2. Auditbeat should be installed.

Steps to Reproduce

  1. Install the elastic rules, 203 rule will be installed and upgrade the build to 7.10.0
  2. Now navigate to Detection Rules under the detection tab.
  3. "Update 101 Elastic prebuilt rules" button is displaying with 203 elastic rules.
  4. Now click on "Update 101 Elastic prebuilt rules" and observe that the total count displayed under elastic rules is 322

Impacted Test case(s)
N/A

Actual Result
The incorrect count is displayed in "Update 101 Elastic prebuilt rules" under Detections rules when upgraded the build from 7.9.2 to 7.10.0.

Expected Result
The correct count should be displayed in "Update 101 Elastic prebuilt rules" under Detections rules when upgraded the build from 7.9.2 to 7.10.0.

What's Working
N/A

What's not Working
N/A

Screenshot:

  • During Upgrade:
    prbuilt

  • After Upgrade
    after_upgrade_count

@ghost ghost added bug Fixes for quality problems that affect the customer experience Team:SIEM labels Oct 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@ghost
Copy link
Author

ghost commented Oct 14, 2020

@manishgupta-qasource Please Review

@spong
Copy link
Member

spong commented Oct 14, 2020

We've got #80389 in flight which will fix the text when timelines have already been installed. Once merged (so we don't conflict), we can update the text to be something along the lines:

  • Update {updateRules} and install {newRules} new Elastic prebuilt rules.
  • Update {updateRules} Elastic prebuilt rules.
  • Install {newRules} new Elastic prebuilt rules.

@spong spong added the v7.10.0 label Oct 14, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security Solution)

@MadameSheema
Copy link
Member

@deepikakeshav-qasource can you please validate this ticket once 7.10BC3 is available in Cloud? Thanks :)

@MadameSheema MadameSheema assigned ghost and unassigned peluja1012 and spong Oct 22, 2020
@ghost
Copy link
Author

ghost commented Oct 26, 2020

Hi @MadameSheema,

We have validated this ticket on 7.10.0 BC3 build and observed that issue is not fixed yet. The incorrect count is still displaying under Detections rules when upgraded the build from 7.9.2 to 7.10.0.

Build Details:

Commit : ed66f41a8a60ad03426beff65ed270a743c46ac4
Build : 35817
Artifact page: https://staging.elastic.co/7.10.0-aea04452/summary-7.10.0.html

Screenshots:

  • Before upgrade
    before_update

  • After upgrade
    after_update

Thanks!!

@ghost ghost assigned MadameSheema and unassigned ghost Oct 26, 2020
@MadameSheema
Copy link
Member

@peluja1012 @spong are we still targeting the fix for 7.10? thanks :)

@MadameSheema MadameSheema removed their assignment Oct 26, 2020
@spong
Copy link
Member

spong commented Oct 26, 2020

This will have to wait for now it seems @MadameSheema -- the fix is low impact enough that it can be backported to 7.10.1 though.

@spong spong removed the v7.10.0 label Oct 26, 2020
@MindyRS MindyRS added the Feature:Detection Rules Anything related to Security Solution's Detection Rules label Oct 27, 2020
@peluja1012 peluja1012 added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Oct 28, 2020
@ghost
Copy link
Author

ghost commented May 6, 2021

Hi @MadameSheema,

We have validated this ticket on 7.13.0 BC4 build and observed that issue is still ocurring. Update {updateRules} and install {newRules} new Elastic prebuilt rules are not displayed when upgrade the build.

Build Details:

Version:7.13.0 BC4
Commit:5a6bad454ffe263aafed54cbd3f764253694bf37
Build:40749

Screenshot:
Elastic_rules
after_update_elastic_rule

Thanks!!

@ghost ghost added the Theme: rac label obsolete label Aug 11, 2021
@ghost
Copy link
Author

ghost commented Aug 16, 2021

Hi @MadameSheema ,

We have validated this ticket on 7.15.0-SNAPSHOT build and found that issue is Still Occurring.

Build Details:

Version:7.15.0 SNAPSHOT
Commit:aa12d107c38c5cda96fc32bcd1f8226df172826a
Build:43370

Screenshot:
image

image

Thanks.

@spong
Copy link
Member

spong commented Nov 16, 2021

Still present as of reviewing latest 7.16 rules PR: #118657.

Also linking these two enhancement requests for improving this upgrade UI/UX as perhaps these efforts can be bundled to re-work this UX:
#88563
#92553

@banderror banderror added Team:Detection Rule Management Security Detection Rule Management Team and removed Team:SIEM v7.10.0 labels Nov 17, 2021
@banderror banderror added the 8.2 candidate considered, but not committed, for 8.2 release label Feb 15, 2022
@banderror banderror added Feature:Rule Management Security Solution Detection Rule Management 8.3 candidate and removed Feature:Detection Rules Anything related to Security Solution's Detection Rules Theme: rac label obsolete v8.2.0 8.2 candidate considered, but not committed, for 8.2 release labels Apr 11, 2022
@banderror banderror added Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules and removed Feature:Rule Management Security Solution Detection Rule Management 8.3 candidate labels Apr 26, 2022
@banderror banderror changed the title [Bug] The incorrect count is displayed in "Update 101 Elastic prebuilt rules" under Detections rules when upgraded the build from 7.9.2 to 7.10.0. [Security Solution] The incorrect count is displayed in "Update 101 Elastic prebuilt rules" under Detections rules when upgraded the build from 7.9.2 to 7.10.0. Mar 28, 2023
@banderror
Copy link
Contributor

We can close this now. We've reworked the whole workflow for installing and upgrading prebuilt rules in #158450, and the callout mentioned in this bug doesn't exist anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.9 candidate bug Fixes for quality problems that affect the customer experience Feature:Prebuilt Detection Rules Security Solution Prebuilt Detection Rules fixed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.9.0
Projects
None yet
Development

No branches or pull requests

8 participants