New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable eslint rules #8119

Closed

6 tasks

spalger opened this issue Aug 29, 2016 · 1 comment

Contributor

spalger commented Aug 29, 2016

Once #8101 is merged, the following rules will be disabled, and the linked pull requests can be used to reenable them.

reenable no-var: re-enable no-var rule and autofix violations spalger/kibana#19
reenable prefer-const: re-enable and autofix prefer-const rule spalger/kibana#20
reenable no-extra-semi: re-enabled and autofix no-extra-semi rule spalger/kibana#21
reenable quotes: re-enable and autofix quotes rule spalger/kibana#22
reenable no-unused-vars: re-enabled and fix no-unused-vars rule spalger/kibana#23

optional:

object-curly-spacing rule: experiment with enforcing object-curly-spacing with eslint spalger/kibana#24

This was referenced Aug 29, 2016

Upgrade eslint #8101

Closed

Final eslint upgrade #8120

Closed

Contributor Author

spalger commented Aug 29, 2016

this has been too tricky to manage, switching to one commit per reviewable unit

spalger closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment