Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SavedObjects: refactor the export code and move it to the SO client #82077

Closed
pgayvallet opened this issue Oct 29, 2020 · 2 comments
Closed

SavedObjects: refactor the export code and move it to the SO client #82077

pgayvallet opened this issue Oct 29, 2020 · 2 comments
Labels
chore Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

pgayvallet commented Oct 29, 2020

exportSavedObjectsToStream (src/core/server/saved_objects/export/get_sorted_objects_for_export.ts) has almost been untouched when migrated to KP. We should refactor this to do the following:

  • stop exporting it as a static function, and add a new exportSavedObjects or export API to the SO client / repository instead (which would also allow hidden types / custom clients to export their objects)
  • get rid of the Boom errors usages
  • cleanup and improve the types used in the underlying call chain.
@pgayvallet pgayvallet added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:Saved Objects labels Oct 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor Author

This has been addressed when we moved Core code to packages and introduced the @kbn/core-saved-objects-import-export-server-internal package.

Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Saved Objects Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

No branches or pull requests

2 participants