Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] react-syntax-highlighter has started to treat linebreaks differently #85356

Closed
2 tasks
sorenlouv opened this issue Dec 8, 2020 · 2 comments
Closed
2 tasks

[APM] react-syntax-highlighter has started to treat linebreaks differently #85356

sorenlouv opened this issue Dec 8, 2020 · 2 comments
Labels
Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture

Comments

@sorenlouv
Copy link
Member

After updating react-syntax-highlighter in #84296 was necessary to modify the linebreak behaviour: 2be72fa

We should do two things:

  • Look into why this was necessary and if there is a better solution
  • Add a test that will catch changes like this in the future
@sorenlouv sorenlouv added [zube]: Inbox Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture labels Dec 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@smith
Copy link
Contributor

smith commented Sep 22, 2021

EuiCodeBlock supports line numbers as of elastic/eui#4993, so we can replace the code we're using with that now. Closing this.

@smith smith closed this as completed Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Team:APM All issues that need APM UI Team support technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@smith @dannycroft @sorenlouv @elasticmachine