Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply access controls to Saved Object and documents via Tags #90646

Open
woodywalton opened this issue Feb 8, 2021 · 8 comments
Open

Apply access controls to Saved Object and documents via Tags #90646

woodywalton opened this issue Feb 8, 2021 · 8 comments
Labels
discuss Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@woodywalton
Copy link

Describe the feature: With the expanded capabilities of applying Tags to Saved Objects in Kibana 7.11, the thought occurred that it would be useful to be able to apply security controls to both documents and Saved Objects based on the assigned Tag(s). Will need to also consider who will have permissions to apply Tags (perhaps the user has to have the same role/permissions in order to be able to apply that Tag) along with security rule precedence/inheritance logic.

Describe a specific use case for the feature: Easiest example use case would be in a security context, but I could imagine the same pattern being useful for content administrators or investigation teams: it would be really cool to have a set of RBAC/ABAC access rules pre-defined and when you come across for example a security concern (say, in a Timeline), add a tag to it and immediately remove general access until it has been resolved.

@alexfrancoeur

@Jaraxal
Copy link
Member

Jaraxal commented Feb 8, 2021

Applying security controls to tags is a natural next step. When customers have dozens of dashboards and/or visualizations, it would be far simpler to control access via the tags than to manage them individually. I would like to see this feature as well.

@nickpeihl nickpeihl added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Feb 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@pgayvallet pgayvallet added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Feb 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@pgayvallet
Copy link
Contributor

pgayvallet commented Feb 12, 2021

Applying security controls to tags is a natural next step. When customers have dozens of dashboards and/or visualizations, it would be far simpler to control access via the tags than to manage them individually

Isn't that what spaces are for?

Since the beginning of their conception, tags were always meant to be for categorizing and filtering purposes only, and never to be a replacement or equivalence to spaces.

I'm not saying that I think this wouldn't make sense, as I actually think it does. However, having RBAC based on tags has quite a lot of technical implications, some of which wouldn't even be resolved when OLS lands. So I would really like to start with a simple question, to try to understand more what such a feature would provide:

What would tag-based access control provide that spaces don't already today, and can't we improve our spaces features instead?

cc @elastic/kibana-security
cc @kobelb (told you)

@woodywalton
Copy link
Author

HI @pgayvallet, first of all can you explain 'OLS' - perhaps we're not aware of some coming functionality that addresses this?

To your comment: Spaces does allow for document and feature access within Kibana, but only if you have already identified the users/roles/content to be separated - this use case would give the ability for a high level security admin to use tags to apply RBAC controls on data during the triage process to help prevent leakage as soon as issues are seen.

There are probably many other, not strictly Security-related use cases as well... I can imagine a content administrator using tags to direct new content into a SME's workflow, for instance.

@rudolf
Copy link
Contributor

rudolf commented Feb 17, 2021

From my perspective here are the differences between spaces (with sharing to multiple spaces coming in 8.0) and tags:

Spaces Tags
Users have to enter into a space to see saved objects in that space. Even if users have access to two spaces they can only see the objects of one space at a time. Users can see all saved objects with all tags (but can filter by tag if they want)
There is very limited UI integration with spaces in Kibana. Spaces are only really visible from the spaces selector and in saved objects management. Tags are deeply integrated into every Kibana application (at least that’s the vision). E.g. you can directly assign or remove tags from the dashboard itself, no need to switch to a different app.

The better UI integration makes tags feel light and flexible whereas spaces feel more rigid and permanent.

@jportner
Copy link
Contributor

HI @pgayvallet, first of all can you explain 'OLS' - perhaps we're not aware of some coming functionality that addresses this?

You can read more about Object Level Security here: #39259

We've started some exploratory work on the first phase of OLS (linked within that meta-issue), but the MVP is a ways off.

@woodywalton
Copy link
Author

Thanks @jportner - have heard vaguely about Object Level Security and am excited about it, thanks for expanding the acronym and the link!

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Aug 5, 2021
@legrego legrego removed EnableJiraSync loe:small Small Level of Effort impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Aug 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

No branches or pull requests

8 participants